Problem with return false

Hey

When I make /fragen <Message> then the Usage from the plugins.yml appears. Why? Normally, the Usage of the Command just appears, when the Plugins comes to the return false. But it doesn't and do it too. When I use the /fragen command and a player is on the server and in the pList, it funcs. I dont know why

Here's the Code from the Main:

Code:java

package tk.stjubit.main;
 
import java.io.File;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Vector;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
 
    File file = new File("plugins/SimpleHelp","playerlist.yml");
    FileConfiguration list = YamlConfiguration.loadConfiguration(file);
 
    public static ArrayList<String> pList=new ArrayList<>();
 
    @Override
    public void onEnable() {
        System.out.println("[SimpleHelp] Vollstaendig geladen!");
 
        if(!file.exists())
        {
            try {
                file.createNewFile();
                list.set("players","");
                list.save(file);
 
            } catch (IOException e) {
                System.out.println("[SimpleHelp] Der Ordner ist nicht gefunden worden!");
            }
        }
        else
        {
            pList=(ArrayList<String>) list.getList("players");
        }
 
        this.getCommand("fragen").setExecutor(new Fragen());
        this.getCommand("fragenadd").setExecutor(new Fragenadd());
    }
 
    @Override
    public void onDisable() {
        System.out.println("[SimpleHelp] Wird geschlossen!");
    }
 
}
 

Heres the Code from the Fragen Command:

Code:java

package tk.stjubit.main;
 
import java.io.File;
import java.util.ArrayList;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Fragen extends JavaPlugin implements CommandExecutor {
 
    File file = new File("plugins/SimpleHelp","playerlist.yml");
    FileConfiguration list = YamlConfiguration.loadConfiguration(file);
 
    ArrayList<String> pList=Main.pList;
 
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label,
            String[] args) {
 
        if(cmd.getName().equalsIgnoreCase("fragen"))
        {
            System.out.println("asd");
            if(!(sender instanceof Player))
            {
                System.out.println("[SimpleHelp] Dieses Command ist nur InGame verfuegbar!");
                return true;
            }
 
            Player p=(Player) sender;
            sender.sendMessage("asd");
 
            if(args.length>=1)
            {
                String frage="";
                for(int i=0;i<args.length-1;i++)
                {
                    frage+=args[i]+" ";
                }
 
                for(int i=0;i<pList.size();i++)
                {
                    Player ziel=this.getServer().getPlayer(pList.get(i));
                    if(ziel!=null)
                    {
                        if(ziel.isOnline())
                        {
                            ziel.sendMessage(ChatColor.YELLOW+"[SimpleHelp]"+ChatColor.RED+" "+p.getDisplayName()+" : "+frage);
                        }
                    }
                }
                p.sendMessage(ChatColor.YELLOW+"[SimpleHelp]"+ChatColor.RED+" Frage erfolgreich verschickt!");
                return true;
            }
            else
            {
                p.sendMessage(ChatColor.YELLOW+"[SimpleHelp]"+ChatColor.RED+" /fragen <Frage>");
                return true;
            }
        }
 
        return false;
    }
 
}
[/i]

And heres the Code from the Fragenadd Command:

Code:java

package tk.stjubit.main;
 
import java.io.File;
import java.io.IOException;
import java.util.ArrayList;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
import org.bukkit.command.CommandSender;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.configuration.file.YamlConfiguration;
import org.bukkit.entity.Player;
 
public class Fragenadd implements CommandExecutor {
 
    File file = new File("plugins/SimpleHelp","playerlist.yml");
    FileConfiguration list = YamlConfiguration.loadConfiguration(file);
 
    ArrayList<String> pList=Main.pList;
 
    @Override
    public boolean onCommand(CommandSender sender, Command cmd, String label,
            String[] args) {
 
        if(cmd.getName().equalsIgnoreCase("fragenadd"))
        {           
            if(!(sender instanceof Player))
            {
                System.out.println("[SimpleHelp] Dieses Command ist nur InGame verfuegbar!");
                return true;
            }
 
            Player p=(Player) sender;
 
            if(p.hasPermission("simplehelp.add"))
            {
                if(args.length==1)
                {
                    String pName=args[0].toLowerCase();
                    if(pList.contains(pName))
                    {
                        p.sendMessage(ChatColor.YELLOW+"[SimpleHelp]"+ChatColor.RED+" Dieser Spieler ist bereits in der Liste!");
                        return true;
                    }
                    pList.add(pName);
                    list.set("players", pList);
                    try {
                        list.save(file);
                    } catch (IOException e) {
                    }
                    p.sendMessage(ChatColor.YELLOW+"[SimpleHelp]"+ChatColor.RED+" Spieler "+pName+" wurde erfolgreich hinzugefügt!");
                    return true;
                }
                else
                {
                    p.sendMessage(ChatColor.YELLOW+"[SimpleHelp]"+ChatColor.RED+" /fragenadd <Name: Spieler>");
                    return true;
                }
            }
            else
            {
                p.sendMessage(ChatColor.YELLOW+"[SimpleHelp]"+ChatColor.RED+" Du hast keine Rechte!");
                return true;
            }
        }
 
    return false;
 
    }
 
}
 

Thanks for the help, you guys are awesome!

Mfg,
Stjubit

 

Stjubit
Problem 1: Only your Main class should extend JavaPlugin

Also, try getting rid of all the return trues/falses except for the one at the end of the onCommand() and see what happens.

 

The Gaming Grunts - Thanks

I have tried like you said, but it doesn't make any sense.

The only thing i couldn't change was, that i can't delete the extends JavaPlugin, because when I delete it, I cannot make the this.getServer().getPlayer(); - Command.!

Do you or anyone have another suggestion?

 

Stjubit
Why not do Bukkit.getServer().getPlayer() ?

 

The Gaming Grunts
Oh, Dumb

But it don't funk, anyway! :/

 

Stjubit
wut?

 

The Gaming Grunts
It's not working :/

 

Stjubit Can you show us your plugin.yml please?

 

Th3Br1x
sure, here it is:

Code:

name: SimpleHelp
author: Stjubit
version: 1.0
main: tk.stjubit.main.Main
commands:
  fragenadd:
    usage: /fragenadd <Spieler>
    description: Fuegt einen Spieler der Fragenliste hinzu
  fragen:
    usage: /fragen <frage>
    description: Sendet allen Admins Mods und Supps deine Frage

 

I notice you haven't registered the command. I'm not sure it will help because JavaPlugin also has an onCommand method that you can override, but for a CommandExecutor to execute a command, you need to add

Code:java

public class MyPlugin extends JavaPlugin {
 
//Method called when your plugin starts
@Override
public void onEnable() {
//Then register each command of the plugin.yml using it's own CommandExecutor
getCommand("fragen").setExecutor(new MyCommandExecutor());
 

[Edit] If your main class is also a command executor, you'll need to replace "new MyCommandExecutor() by "this" by the way

 

Read the starting topic again please, he had this already implemented.

Stjubit Do you have any errors in the console?
Or is it only the usage message in the ingame-chat?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Th3Br1x
There are no errors, it is the usage ingame!

It don't work anyways.

Th3Br1x Can you add me in Skype? I am from Austria too! (german)

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I can (i'm not even from austria XD). I pm you my name.

 

Your pList array has a chance of being empty.

Code:java

if(!file.exists()) {
// pList is empty here
} else {
// pList gets populated here
}

and while I'm here, don't ever String concatenate in a loop. Every time through the loop it creates a new string and copies the other two to it, very inefficient. Use a StringBuilder. And try to avoid for loops when iterators are available, also less efficient.

Code:java

 StringBuilder frage= new StringBuilder();
for(String i : args)
{
frage.append(args[i]);
frage.append(" ");
}
 
// String allArgs = frage.toString();
[/i]

 

It's not. He just did a mistake extending the JavaPlugin class, but this was already mentioned and corrected.