Lightning Strike EventHandler Help

What am I missing here??

Code:

package com.ultimatehg.thunder;
 
import org.bukkit.Material;
 
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public final class UHG extends JavaPlugin implements Listener{
 
    @EventHandler
    public void onPlayerInteractBlock(PlayerInteractEvent evt){
        if(evt.getPlayer().getItemInHand().getTypeId() == Material.STONE_AXE.getId()){
            //maximal distance between player and thunder is 200 blocks
            evt.getPlayer().getWorld().strikeLightning(evt.getPlayer().getTargetBlock(null, 200).getLocation());
            PluginManager pm = this.getServer().getPluginManager();
            pm.registerEvents(this, this);
        }
    }
}

 

Register your events in your onEnable(), not in your listener:

Code:java

public void onEnable(){
  PluginManager pm = getServer().getPluginManager();
  getLogger().info("Enabled!");
  pm.registerEvents(this, this);
}

 

Code:

package com.ultimatehg.thunder;
 
import org.bukkit.Material;
 
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public final class UHG extends JavaPlugin implements Listener{
 
    @EventHandler
    public void onPlayerInteractBlock(PlayerInteractEvent evt){
        if(evt.getPlayer().getItemInHand().getTypeId() == Material.STONE_AXE.getId()){
            //maximal distance between player and thunder is 200 blocks
            evt.getPlayer().getWorld().strikeLightning(evt.getPlayer().getTargetBlock(null, 200).getLocation());
            PluginManager pm = this.getServer().getPluginManager();
            pm.registerEvents(this, this);
        }
    }
 
public void onEnable(){
PluginManager pm = getServer().getPluginManager();
getLogger().info("Enabled!");
pm.registerEvents(this, this);
}
}

Not sure if I put the onEnable in right spot ,or what to do with it

 

Yeah, but you don't need to register the events in the listener method (onPlayerInteractBlock).

So your class would look like this:

Code:java

package com.ultimatehg.thunder;
 
import org.bukkit.Material;
 
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerInteractEvent;
import org.bukkit.plugin.PluginManager;
import org.bukkit.plugin.java.JavaPlugin;
 
public class UHG extends JavaPlugin implements Listener{
 
    public void onEnable(){
        this.getServer().getPluginManager().registerEvents(this, this);
    }
 
    public void onDisable(){
    }
 
    @EventHandler
    public void onPlayerInteractBlock(PlayerInteractEvent evt){
        if(evt.getPlayer().getItemInHand().getTypeId() == Material.STONE_AXE.getId()){
            //maximal distance between player and thunder is 200 blocks
            evt.getPlayer().getWorld().strikeLightning(evt.getPlayer().getTargetBlock(null, 200).getLocation());
        }
    }
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

lcpvp please note that your code would fail with an error if you look up in the sky (as there would be no target block, so getTargetBlock() would return null, and calling .getLocation() on null would throw a NullPointerException)

 

Alright, thanks.

How would i add a cooldown??

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

HashMap<String,Long> which stores the playername and the timestamp of the last used.
The HashMap:

Code:java

HashMap<String,Long> cooldown = new HashMap<String,Long>(); 

The cooldown part:

Code:java

if(System.currentTimeMillis() - (cooldown.contains(player.getName()) ? cooldown.get(player.getName()) : 0) >= COOLDOWN_IN_MILLISECONDS)
{
    // do command/event
    cooldown.put(player.getName(), System.currentTimeMillis());
}
else
{
    player.sendMessage("You cannot use this yet, still cooling...");
}

 

i dont really get hashmaps...

 

How not?

 

lcpvp
If you ever learned python, they are like dictionaries.

So, pretty much, you start a HashMap like this:

Code:java

HashMap<Object, Object> hashmap_name = new HashMap<Object, Object>();

And, whenever you want to put something in, you do this:

Code:java

hashmap_name.put(Object, Object);

So lets say a plugin has error codes from 1 to 100. The dev wants to translate the error codes to String messages. A HashMap would be good here.

Code:java

package hashmap;
 
public class ErrorHandeling {
 
HashMap<Integer, String> error = new HashMap<Integer, String>();
 
public ErrorHandeling(){
 
error.put(1, "This is an error");
.
.
.
error.put(100, "This is the final error");
 
}
 
public String getErrorMessage(int key){
 
return error.getKey(key);
 
}
 

So, whenever an error 1 occurrs, the plugin will send the CommandSender:

Code:

This is an error.

I hope this helped.

EDIT: Just realized this was almost exactly a year until last post