Args[0] question? or not working?

I have an plugin called gunmaster, and i have commands with more aurguments!
If you typed /gunmaster it does send the message, but if you typ /gunmaster help it does say the gunmaster message, and not the help messsage! Anyone know what i am doning wrong?

i have put the commands in my plugin.yml and
Here is my code:

Code:java

 public boolean onCommand(CommandSender sender, Command cmd, String label, String args[]){
if(!(sender instanceof Player)){
sender.sendMessage(MsgType.CONSOLE + "Only players can use this command!");
return true;
}
 
Player p = (Player) sender;
 
if (ArenaManager.getManager().isInGame(p)) {
p.sendMessage(MsgType.DENIED + "You can not use commands ingame");
}
 
if (cmd.getName().equalsIgnoreCase("gunmaster")) {
p.sendMessage(ChatColor.GOLD + "------------ " + MsgType.NORMAL + "--------------------");
p.sendMessage(ChatColor.GOLD + "Developed by: " + ChatColor.GRAY + "jusjus112");
p.sendMessage(ChatColor.GOLD + "Version: " + ChatColor.GRAY + " 0.5");
p.sendMessage(ChatColor.GOLD + "Minecraft version: " + ChatColor.GRAY + "1.7.2");
p.sendMessage(ChatColor.YELLOW + "Typ /gm help for an list of commands.");
return false;
}
if (args.length > 0) {
if (args[0].equalsIgnoreCase("help")) {
p.sendMessage(MsgType.NORMAL + "/gm join"
+ "/gm leave"
+ "/gm create"
+ "/gm remove");
return true;
}
return false;
}

 

I think it's because you have if(args.length > 0)

Try

if(args.length == 0)

 

thepaperboy99
Sorry, but i did have tried that!
It says again the same thing under the command /gunmaster not the /gunmaster help?

And if i put "Return true;"
under the gunmaster command, it dont work

 

Code:java

if (cmd.getName().equalsIgnoreCase("gunmaster")) {

When you type /gunmaster help, this statement is true, so it runs all the code after it and then returns false. Incidentally, you're then checking if args[0] is help regardless of what the command name is.
Your code should look like this:

Code:java

 
if (cmd.getName().equalsIgnoreCase("gunmaster")) {
    if(args.length == 0) {
        //. . .
    }
    else if(args.length == 1){ //Technically could just be "else", but this is better practice
        if(args[0].equals("help") {
            //. . .
        }
    }
}
 

 

oke, it works
Thanks adam753

adam753
I have quickly reopened this thread with one more question!
If i typ /gumaster delete <arenaNumber>
it does not work, but if i typed /gunmaster delete. Then he says with arena number 0
What i doning wrong? I cant go to args[1] or sometghing. Only args[0] works!
Code: I got the error in line 6!

Code:java

      if (args.length == 1) {
if (args[0].equalsIgnoreCase("delete")) {
}
int num = 0;
try{
num = Integer.parseInt(args[0]);
}catch(NumberFormatException e){
p.sendMessage(MsgType.DENIED + "Invalid arena " + num);
}
ArenaManager.getManager().removeArena(num);
p.sendMessage(MsgType.NORMAL + "Removed arena " + num);
return true;
}

And my error:

PHP:

22.12 17:24:47 [Server] INFO ... 15 more
22.12 17:24:47 [Server] INFO at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
22.12 17:24:47 [Server] INFO at gunmaster.Main.onCommand(Main.java:82)
22.12 17:24:47 [Server] INFO Caused by: java.lang.ArrayIndexOutOfBoundsException: 1
22.12 17:24:47 [Server] INFO at net.minecraft.server.v1_6_R3.ThreadServerApplication.run(SourceFile:583)
22.12 17:24:47 [Server] INFO at net.minecraft.server.v1_6_R3.MinecraftServer.run(MinecraftServer.java:421)
22.12 17:24:47 [Server] INFO at net.minecraft.server.v1_6_R3.MinecraftServer.s(MinecraftServer.java:488)
22.12 17:24:47 [Server] INFO at net.minecraft.server.v1_6_R3.DedicatedServer.t(DedicatedServer.java:227)
22.12 17:24:47 [Server] INFO at net.minecraft.server.v1_6_R3.MinecraftServer.t(MinecraftServer.java:592)
22.12 17:24:47 [Server] INFO at net.minecraft.server.v1_6_R3.DedicatedServerConnection.b(SourceFile:30)
22.12 17:24:47 [Server] INFO at net.minecraft.server.v1_6_R3.ServerConnection.b(SourceFile:37)
22.12 17:24:47 [Server] INFO at net.minecraft.server.v1_6_R3.PlayerConnection.e(PlayerConnection.java:116)
22.12 17:24:47 [Server] INFO at net.minecraft.server.v1_6_R3.NetworkManager.b(NetworkManager.java:296)
22.12 17:24:47 [Server] INFO at net.minecraft.server.v1_6_R3.Packet3Chat.handle(SourceFile:49)
22.12 17:24:47 [Server] INFO at net.minecraft.server.v1_6_R3.PlayerConnection.a(PlayerConnection.java:837)
22.12 17:24:47 [Server] INFO at net.minecraft.server.v1_6_R3.PlayerConnection.chat(PlayerConnection.java:886)
22.12 17:24:47 [Server] INFO at net.minecraft.server.v1_6_R3.PlayerConnection.handleCommand(PlayerConnection.java:968)
22.12 17:24:47 [Server] INFO at org.bukkit.craftbukkit.v1_6_R3.CraftServer.dispatchCommand(CraftServer.java:528)
22.12 17:24:47 [Server] INFO at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:192)
22.12 17:24:47 [Server] INFO at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
22.12 17:24:47 [Server] INFO org.bukkit.command.CommandException: Unhandled exception executing command 'gm' in plugin ZombieSurvival v0.1

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You don't really seem to understand what the brackets do...
It checks if the args is 0. If so it does absolutely nothing. Then it parses args[0] (which would be delete, just saying) and beacause it's "delete" nothing happens. None of your code makes any sense.
Click this.

 

Yes, I agree with GarrisOn, you must understand what an array means, and what it means in case of ingame commands. The command "/gunmaster delete <area>" will result the following arguments:

Code:java

label == "gunmaster"
args == String[] { "delete", "<arena>" } which means:
args[0] == "delete"
args[1] == "<arena>"

args.lenth means how many record is has, so in this case args{"delete", "<arena>"}.lenth == 2

So you will handle that this way:
(I do my comands this way)

Code:java

if (label.toLowerCase().equalsIgnoreCase("gunmaster")) {
  if (args.lenth > 0) { //there are arguments after the main command
    if (args[0].toLowerCase().equalsIgnoreCase("delete")) { //if the first argument is "delete"
      if (args.length == 2) { //there are two arguments after "/gunmaster"
        try { int num = Inteher.parseInt(args[1]); }
        catch(NumberFormatException nfe) {
          sender.sendMessage("§4Arena id must be a number!"); //§4 is red color code
          return true;
        }
        ArenaManager.getManager().removeArena(num);
        sender.sendMessage("§2Arena #" + num + " has been successfully removed."); //§2 is green color code
      } else {
        sender.sendMessage("§7Right syntax: /gunmaster delete <arena id>"); //
        return true;
      }
    } else {
        sender.sendMessage("No gungame command like that.");
        sender.sendMessage("Commands:");
        sender.sendMessage("  /gunmaster delete <arena-id>");
    }
  } else { //there are no arguments, the command is only "/gunmaster"
    //Do the "/gunmaster" command
  }
  return true;
}
return false;

Edit: yep so many edits, i'm not home and there are so many if methods with {} marks