Easy Java Question

Hello community,
I am having a simple java issue. So I have a class, which is a manager. I also have the base class, which stores information on the player. This is my issue, when I make a player, it uses the base class then stores all of the information in a list of the base class. But when I try to access the same player again the data is not there. I have looked in the logs but nothing. The only thing that I could think of was that the instances where not the same. If that is the case then I have no idea how to fix it. If you need more information about how the classes work together then let me know. Any help would be nice.
Thank community you rarely fail me,
The_Coder

 

Can you post some more details? Some actual code perhaps? And what do you mean by "creating a player". All instances of the Player class should be initialized by bukkit and passed to you by events.

 

Your name makes me die inside.

And what are you trying to actually achieve?

 

$10 on static instances gone wrong, or incorrect passing / reference of classes.

 

Ok. Well I have a base class:

Code:java

 public class BasePlayer {
 
private String name;
private String brush;
 
public BasePlayer(String name, String brush) {
 
this.name = name;
this.brush = brush;
 
}
 
public void setName(String name) {
this.name = name;
}
 
public void setBrush(String brush) {
this.brush = brush
}
 
// Some more stuff...
 
} 

Then I have another class which holds all of these:

Code:java

 
public class BasePlayerManager {
 
List<BasePlayer> bps = new ArrayList<BasePlayer>();
 
// A bunch of checking methods and getters and setters for the arraylist...
 
}
 
 

I put the player in the list via another class, and then right after entering the data I tried to get the data out and a npc appered. I have no idea why it is doing this.

You are soo right I think that is the problem to. Of course I was so eager to code bukkit I didn't finish all the tutorials on newboston's channel. Doesn't help that I was looking at the most confusing plugin: VoxelSniper.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I'm still confused. Why would an NPC spawn after attempting to access a list that only holds objects that contain strings?

The_Coder learn java to a better proficiency that the new Boston teaches. And don't look at other plugins. The Bukkit api is very well documented. Its very easy to learn

 

Well if I didn't try to get the data out then it doesn't throw the npc.

 

Can we see the code where you're adding a BasePlayer to that list and accessing it?

Also, you shouldn't be initializing the ArrayList in the instance variable area of the BasePlayerManager class.
List<BasePlayer> bps = new ArrayList<BasePlayer>(); //bad coding practice
You should only declare it then initialize it in the constructor.
List<BasePlayer> bps;
...
public BasePlayerManager(){
bps = new ArrayList<BasePlayer>();
}
That alone might be the problem, if I remember my Java correctly after abandoning it for so long. Or at least it's just bad practice with no real functional consequence.

 

Well here is where the Base class gets added to the manager:

Code:java

public void addPlayer(Player player) {
        if(!bps.contains(getPlayerByName(player))) {
            BasePlayer bp = new BasePlayer();
            bp.setPlayer(player.getName());
            bp.setCurrentBrush("");
        }
    }

 

You never did bps.add(bp).

 

Holy crap thanks man!!!!!!

Well that is one problem but I still get the npc when getting stuff out. :/

Got everything working thanks though.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Your welcome