Cancelling item dropping

Hello, I'm having a problem with cancelling the item dropping in the inventory slot #8 (9. in hotbar).
When I cancel the event, the item gets moved to the first free slot from 0 to 8. I would like to cancel the event and leave the item where it is.

Code:java

 
@EventHandler
public void onPlayerDropItem(PlayerDropItemEvent e) {
 
Player player = e.getPlayer();
PlayerInventory playerInventory = player.getInventory();
 
if(playerInventory.getHeldItemSlot() == 8) {
 
e.setCancelled(true);
 
}
 
}
 

 

- Bump -

 

very weird, tried it myself. I don't really have a good answer. Only way around i can see is to get the item, copy, remove and place back. Wouldn't want to do this though

 

mollekake
Alright, tried this:

Code:java

 
 
@EventHandler
public void onPlayerDropItem(PlayerDropItemEvent event) {
 
Player player = event.getPlayer();
PlayerInventory playerInventory = player.getInventory();
 
if(playerInventory.getHeldItemSlot() == 8) {
 
Item drop = event.getItemDrop();
ItemStack is = drop.getItemStack();
ItemStack isClone = is.clone();
drop.setItemStack(null);
 
playerInventory.setItem(0, isClone);
 
}
 
}
 

Threw me this:

Code:text

 
21:47:31 [WARNING] Failed to handle packet for Limeth/127.0.0.1: java.lang.NullP
ointerException
java.lang.NullPointerException
        at net.minecraft.server.Packet21PickupSpawn.<init>(SourceFile:23)
        at net.minecraft.server.EntityTrackerEntry.b(EntityTrackerEntry.java:383
)
        at net.minecraft.server.EntityTrackerEntry.updatePlayer(EntityTrackerEnt
ry.java:304)
        at net.minecraft.server.EntityTrackerEntry.scanPlayers(EntityTrackerEntr
y.java:369)
        at net.minecraft.server.EntityTracker.addEntity(EntityTracker.java:103)
        at net.minecraft.server.EntityTracker.track(EntityTracker.java:55)
        at net.minecraft.server.WorldManager.a(WorldManager.java:18)
        at net.minecraft.server.World.a(World.java:938)
        at net.minecraft.server.WorldServer.a(WorldServer.java:718)
        at net.minecraft.server.World.addEntity(World.java:931)
        at net.minecraft.server.World.addEntity(World.java:876)
        at net.minecraft.server.EntityHuman.a(EntityHuman.java:454)
        at net.minecraft.server.EntityHuman.a(EntityHuman.java:447)
        at net.minecraft.server.EntityHuman.bR(EntityHuman.java:397)
        at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:501)
        at net.minecraft.server.Packet14BlockDig.handle(SourceFile:46)
        at net.minecraft.server.NetworkManager.b(NetworkManager.java:290)
        at net.minecraft.server.NetServerHandler.d(NetServerHandler.java:113)
        at net.minecraft.server.ServerConnection.b(SourceFile:39)
        at net.minecraft.server.DedicatedServerConnection.b(SourceFile:30)
        at net.minecraft.server.MinecraftServer.r(MinecraftServer.java:595)
        at net.minecraft.server.DedicatedServer.r(DedicatedServer.java:222)
        at net.minecraft.server.MinecraftServer.q(MinecraftServer.java:493)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:426)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:856)
 

 

try that with drop.setItemStack(new ItemStack(Material.AIR, 0));

 

Alright, tried that but that did not change anything. Still getting the error.

 

Weird. Could you tell me what

Code:java

System.out.println(drop.getItemStack().toString();

prints after you set it to AIR?

 

It prints out "ItemStack{AIR x 0}", like expected.
EDIT: The error appears after the message.

 

try it with amount 1:

Code:java

new ItemStack(Material.AIR, 1);

 

Null Pointer Exception again. =(

 

You can try this:

Code:

@EventHandler
public void onPlayerDropItem(PlayerDropItemEvent e) {
 
Player player = e.getPlayer();
PlayerInventory playerInventory = player.getInventory();
ItemStack[] contents = playerInventory.getContents();
 
if(playerInventory.getHeldItemSlot() == 8) {
 
e.setCancelled(true);
playerInventory.setContents(contents);
 
}
 
}

 

Try this:

Code:

@EventHandler(priority=EventPriority.NORMAL, ignoreCancelled=false)
public void onDropItem(PlayerDropItemEvent e) {
 
    Player p = e.getPlayer();
   
    if (p.getInventory().getHeldItemSlot() == 8) {
        e.setCancelled(true);
        p.sendMessage("You can't drop something out of the 9. item slot!");
    }
   
}

 

If just cancelling the event still puts the item in the first slot, submit a bug report on the leaky.

 

No it doesn't do it...
It's working very well - the only bad is that it's spamming the message.

A picture:

 

That is really weird, I tried that, but it still puts the item to the first hot-bar slot available. I'm using CB 1.4.5-R2.0.

https://bukkit.atlassian.net/browse/BUKKIT-3028

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

If this error cannot be confirmed by someone else, do not submit a leaky ticket for the problem please.

 

Alright, that also did not help me, TnT .

 

For me all is working well.
I use 1.4.2-R0.2 in the Java Build Path and as Server-Version...

 

Try to remove all plugins except yours?

 

There are no other plugins, would you mind trying the code for yourself, too, please?
EDIT: I can actually upload my server setup with the plugin, if it helps.

Elrontur ZachBora TnT DarkBladee12 fireblast709 mollekake
I've found the difference! If you cancel the event when you're holding in the 8th slot 2 or more items, it cancels perfectly, without any weird actions. BUT when you hold only one item in the slot and you press 'Q', then it acts weird! As I said, it puts the item to the first empty hotbar slot!
Any ideas?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I would do it manually if Bukkit is acting up. Set the item to air, then put it back in their inventory in whatever slot you want, instead of canceling the event.

 

http://forums.bukkit.org/threads/cancelling-item-dropping.111676/#post-1426359 Ehm -.-

 

Having the same problem with 1.6.2-R0.1 and the newest build for 1.6.2. Multipile items are working, a single item gets added to the nerarest slot to slot #0.

Edit: running no other plugins, this is a bukkit issue.

 

Bump? Any solutions for this weird bug?

 

Submit a leaky ticket

 

Just thought I'd clear this up: In the CraftBukkit event, what happens is the drop item is created. The item is removed from the players inventory. The event is called. If the event is cancelled, a return; is called and the item is added to the players inventory with **.addItem**. This means, if you drop an item in the 9th slot, the next available is the 1st, so it goes to that. If there are 2+ items, the closest stack for it to join with is the 9th one, so the event cancellation works as expected. This can be fixed by either changing this .addItem to a .setItem call in bukkit, or, until bukkit fixes this, calling event.getDrop().remove(); and manually using .setItem to set the item IN HAND to the item you want.

 

[item].remove(); ? Did you try that.. ?

 

FadedMystery Tried it, you can say e.remove(); that automaticly removes the events drop. I think what macguy8 described is totaly possible, it's just a weird bug, since it works when the stack you try to drop an item out of has more than 2 items inside. It just appears when the stackzize == 1.

 

Badeye
That's exactly what's happening, per checking CraftBukkit code

 

use that, that works 100%:

Code:Java

 
@EventHandler
public void onItemDrop(PlayerDropItemEvent e){
Player p = e.getPlayer();
ItemStack item = e.getItemDrop().getItemStack().clone();
e.getItemDrop().remove();
p.getInventory().addItem(item);
 
}
 

hope that helped you