InventoryCloseEvent

Hello Guyz

I have made a trade command thats trade the item in your hand with /trade <Player> [Money]

and i have maked if someone press esc or something that the player get his item back

Codes:

Main:

Code:java

package achp;
 
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin{
 
 
 
    public void onEnable(){
        PluginDescriptionFile pdf = this.getDescription();
        getLogger().info(pdf.getName() + " version " + pdf.getVersion() + " has been enabled");
        getServer().getPluginManager().registerEvents(new Events(), this);
    }
 
    public void onDisable(){
        PluginDescriptionFile pdf = this.getDescription();
        getLogger().info(pdf.getName() + " has been disabled");
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String CL, String[] args){
        if(sender instanceof Player){
            Player player = (Player) sender;
            switch(CL.toLowerCase()){
            case "trade":
                if(args.length == 2){
                    Player target = getServer().getPlayerExact(args[0]);
                    if(target instanceof Player){
                        int Money = Integer.valueOf(args[1]);
                        if(Money > -1 && Money < 10000000){
                            Inventory tradinginv = target.getPlayer().getServer().createInventory(null, 9, "Trading");
 
                            ItemStack Accept = new ItemStack(Material.WOOL, 1);
                            ItemMeta Am = Accept.getItemMeta();
                            Am.setDisplayName(ChatColor.GREEN + "Accept");
                            Accept.setItemMeta(Am);
 
                            ItemStack Decline = new ItemStack(Material.WOOL, 1);
                            ItemMeta Dm = Decline.getItemMeta();
                            Dm.setDisplayName(ChatColor.RED + "Decline");
                            Decline.setItemMeta(Dm);
 
                            ItemStack Head = new ItemStack(Material.SKULL, 1);
                            ItemMeta Hm = Head.getItemMeta();
                            Hm.setDisplayName(player.getName());
                            Head.setItemMeta(Hm);
 
                            ItemStack MoneyStack = new ItemStack(Material.GOLD_INGOT, 1);
                            ItemMeta Msm = MoneyStack.getItemMeta();
                            Msm.setDisplayName("Money: " + Money);
                            MoneyStack.setItemMeta(Msm);
 
                            ItemStack TradeItem = new ItemStack(player.getItemInHand().getType(), player.getItemInHand().getAmount());
                            ItemMeta Tim = TradeItem.getItemMeta();
                            Tim.setDisplayName("Item");
                            TradeItem.setItemMeta(Tim);
 
                            tradinginv.setItem(0, Accept);
                            tradinginv.setItem(1, Decline);
                            tradinginv.setItem(6, Head);
                            tradinginv.setItem(7, MoneyStack);
                            tradinginv.setItem(8, TradeItem);
 
                            target.openInventory(tradinginv);
 
                            player.getInventory().setItemInHand(new ItemStack(Material.AIR, 1));
                        }else{
                            player.sendMessage("Sorry your money must be under the 1 million and above -1");
                        }
                    }else{
                        player.sendMessage("Sorry that player isnt online now");
                    }
                }else{
                    player.sendMessage("Usage: /trade <Player> [AmountMoney]");
                }
                break;
            }
        }
        return false;
    }
}
 

Events:

Code:java

package achp;
 
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.inventory.InventoryCloseEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
public class Events implements Listener{
 
 
    @EventHandler
    public void onInventoryEvent(InventoryClickEvent event){
        Inventory inv = event.getInventory();
        if(inv.getName().equalsIgnoreCase("Trading")){
            Player player = (Player) event.getWhoClicked();
            Player target = player.getServer().getPlayerExact(inv.getItem(6).getItemMeta().getDisplayName());
            ItemStack Item = new ItemStack(inv.getItem(8).getType(), inv.getItem(8).getAmount());
            if(event.getCurrentItem().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.GREEN + "Accept")){
                player.getInventory().addItem(Item);
                target.sendMessage("Your item has buyed for " + inv.getItem(7).getItemMeta().getDisplayName());
                event.setCancelled(true);
                player.closeInventory();
            }else if(event.getCurrentItem().getItemMeta().getDisplayName().equalsIgnoreCase(ChatColor.RED + "Decline")){
                target.getInventory().addItem(Item);
                target.sendMessage(player.getName() + " has denied your trade");
                event.setCancelled(true);
                player.closeInventory();
            }else{
                event.setCancelled(true);
                player.sendMessage("Sorry you cant pick that item");
            }
        }
    }
 
    @EventHandler
    public void onInventoryCloseEvent(InventoryCloseEvent event){
        Inventory inv = event.getInventory();
        if(inv.getName().equalsIgnoreCase("Trading")){
            Player player = (Player) event.getPlayer();
            Player target = player.getServer().getPlayerExact(inv.getItem(6).getItemMeta().getDisplayName());
            ItemStack Item = new ItemStack(inv.getItem(8).getType(), inv.getItem(8).getAmount());
            target.getInventory().addItem(Item);
            target.sendMessage(player.getName() + " has closed his inventory");
        }
    }
 
}
 

and my problem is that if the console the inventory closes (If i have pressed Accept or Decline)
he gives the target and me my item

Images:





Can someone help me

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I believe one thing that is happening is that, onInventoryCloseEvent is being called after every transaction and giving the target the item back every time.

onInventoryCloseEvent should only give the target the item if the trade was not accepted.

This does not explain why both parties will recieve the item when the transaction is declined, in fact it seems to me that the target would recieve a duplicate item in that situation. So I am probably missing something.