Solved Need a little bit of help with coding please?

i admit it. i am a bit of a 'noob' towards coding, i started 3 days ago. my plugin isnt working and idk why, i asked my friend who also knows about code and he cant seem to find any errors.

What i want it to do:
Basically, people just type /p and it returns saying "Pinged!"

The Error:
http://gyazo.com/7caaff52a9b43cd91161c3a046f8124b

Main.java:

Code:java

package adyyy1337.simpleping;
 
    import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin{
 
    public void onEnable(){
        System.out.println("SimplePing Has Been Enabled!");
        this.getServer().getPluginManager().registerEvents(new Events(), this);
    }
 
    public void onDisable(){
        System.out.println("SimplePing Has Been Disabled!");
        }   
    }
 

Events.java:

Code:java

package adyyy1337.simpleping;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
 
public class Events implements Listener{
 
    @EventHandler(priority = EventPriority.NORMAL)
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
        Player player = (Player) sender;
        if(commandLabel.equalsIgnoreCase("P"));{
            player.sendMessage(ChatColor.GOLD + "Pinged!");
        }
        return false;
    }
 
}
 

any help would be appreciated, thanks.

 

@adyyy1337 http://wiki.bukkit.org/Plugin_Tutorial#Commands You should probably read this since you use Listeners for events not commands

 

adyyy1337 onCommand is not an event, you do not need to implement Listener.

Also, refer to line 16 @ Events class:

Code:java

if(commandLabel.equalsIgnoreCase("P"));{

You should not have added ";"

Move onCommand to the Main class:

Code:java

package adyyy1337.simpleping;
 
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin
{
    public void onEnable()
    {
        System.out.println("SimplePing Has Been Enabled!");
    }
 
    public void onDisable()
    {
        System.out.println("SimplePing Has Been Disabled!");
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
    {
        Player player = (Player) sender;
        if (commandLabel.equalsIgnoreCase("P")) {
            player.sendMessage(ChatColor.GOLD + "Pinged!");
        }
        return false;
    }
}

 

Also, check "if (sender instanceof Player)" before casting sender to a Player (try running the command from the console as it is), and put a "return true;" after sending the message, otherwise the player will be sent the usage of the command, which you don't want if they did it correctly

 

adyyy1337 Your main issue, is that onCommand is not an event. Remove the @EventHandler, and instead of regestering your events, register your command using the Executor. Heres my tutorial:
http://forums.bukkit.org/threads/tutorial-using-multiple-classes.179833/

 

thanks all, but it says /p when i type /p.
i also added the command info to plugin.yml, maybe i did something wrong there?
when typing /p, this shows up in chat:
http://gyazo.com/bf05ca1dba91721f3d6bc0b829aeefab
Main.java:

Code:java

package adyyy1337.simpleping;
 
import org.bukkit.ChatColor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin{
 
public void onEnable()
{
System.out.println("SimplePing Has Been Enabled!");
}
 
public void onDisable()
{
System.out.println("SimplePing Has Been Disabled!");
 
}
 
public boolean onCommand(CommandSender sender, CommandSender cmd, String commandLabel, String[] args)
{
Player player = (Player) sender;
if(commandLabel.equalsIgnoreCase("P")) {
player.sendMessage(ChatColor.GOLD + "Pinged!");
}
return false;
}
 
}
 

plugin.yml:

Code:

name: SimplePing
version: 1.0
main: adyyy1337.simpleping.Main
commands:
  p:
      description: Used For Testing Server Response Time.
      usage: /<command>
      permission: SimplePing.p
      permission-message: You Do Not Have The Required Permissions.

 

Try

Code:java

if(cmd.getName().equalsIgnoreCase("p"){
player.sendMessage(ChatColor.GOLD + "Pinged!");
return true;
} else {
return false;
}

instead of

Code:java

if(commandLabel.equalsIgnoreCase("P")) {
player.sendMessage(ChatColor.GOLD + "Pinged!");
}

 

nope, still gives me same error.
Main.java(now):

Code:java

package adyyy1337.simpleping;
 
    import org.bukkit.ChatColor;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin{
 
    public void onEnable()
    {
        System.out.println("SimplePing Has Been Enabled!");
    }
 
    public void onDisable()
    {
        System.out.println("SimplePing Has Been Disabled!");
 
    }
 
    public boolean onCommand(CommandSender sender, CommandSender cmd, String commandLabel, String[] args)
    {     
        Player player = (Player) sender;
        if(cmd.getName().equalsIgnoreCase("p")){  // i corrected your typo, 2 close brackets instead of one
            player.sendMessage(ChatColor.GOLD + "Pinged!");
            return true;
            } else {
            return false;
            }     
    }
 
}

 

Hmm, maybe it is because you are not returning false at the end...

Code:java

 public boolean onCommand(CommandSender sender, CommandSender cmd, String commandLabel, String[] args)
    {   
        Player player = (Player) sender;
        if(cmd.getName().equalsIgnoreCase("p")){  // i corrected your typo, 2 close brackets instead of one
            player.sendMessage(ChatColor.GOLD + "Pinged!");
            return true;
        }
        return false;
    }

 

adyyy1337 The example I provided you was correct, however, you have a typo.

Change onCommand to:

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)

You had CommandSender sender, CommandSender cmd...

For the record, as previously suggested by Chinwe, you need to check if the sender is an instance of Player. You can easily do so by adding if (sender instanceof Player) {

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
{
    if (sender instanceof Player) {
        //execute
    }
}

 

3ptO Derp, I just realised that. I had expected that the method's parameters would be correct - it's pretty hardto stuff up. But it should work with his example adyyy1337

 

thank you! it now works. haha, i didnt notice that typo thank you all for your help guys!