Switching Snowballs Help?

I'm trying to make it so when a guy throws a snowball at another guy they switch positions, why doesn't this work

Code:java

public void switchPlaces(Player p1, Player p2) {
        Location l1 = p1.getLocation();
        p1.teleport(p2.getLocation());
        p2.teleport(l1);
        }
 
    @EventHandler(priority = EventPriority.HIGHEST)
    public void onEntityDamageByEntity(EntityDamageByEntityEvent event) {
        Player entity = (Player) event.getDamager();
        Player entity2 = (Player) event.getEntity();
        if (entity instanceof Snowball) {
            switchPlaces(entity, entity2);
        }
    }

please ignore my bad usage of variable names

 

Didn't have time to test this but I think this works...

Code:java

@EventHandler(priority = EventPriority.HIGHEST)
public void onEntityDamageByEntity(EntityDamageByEntityEvent event) {
Player entity = (Player) event.getDamager();
Player entity2 = (Player) event.getEntity();
Location entityloc = entity.getLocation();
Location entity2loc = entity2.getLocation();
entity.teleport(entity2loc);
entity2.teleport(entityloc);
}

EDIT: Sorry, cleaned the code and fixed a typo

 

vtg_the_kid Make sure, that the EntityDamageByEntity is actually called on your server. It isn't for example called, if the hit player is in creative mode, or the server has pvp turned off in the server.properties or the world.

 

the damager is a snowballs and not a player when a snowball hits another players, so
Player entity = (Player) event.getDamager();
will fail

 

try this :

Code:java

    @EventHandler
    public void EntityDamageByEntity(EntityDamageByEntityEvent event){
        Player player = (Player) event.getEntity();
        if(event.getDamager() instanceof Snowball){
            Snowball snowball = (Snowball) event.getDamager();
            Location locationShooter = snowball.getShooter().getLocation();
            Location playerLocation = player.getLocation();
            snowball.getShooter().teleport(playerLocation);
            player.teleport(locationShooter);
        }
    }