Solved Sign Interaction

Hi,

I've got this code, can't find any errors in it, but it doesn't work. Whenever I click a sign, it just doesn't do anything. Eclipse doesn't give me errors, the plugin loads fine, and gives no errors in the console.

Code:java

 @EventHandler
public void onPlayerInteract(PlayerInteractEvent event){
if(event.getAction().equals(Action.RIGHT_CLICK_BLOCK)){
Block clickedblock = event.getClickedBlock();
Player player = event.getPlayer();
if(clickedblock.getTypeId() == Material.SIGN.getId() || clickedblock.getTypeId() == Material.SIGN_POST.getId()){
Sign sign = (Sign) clickedblock;
String Line1 = sign.getLine(0);
String Line3 = sign.getLine(2);
String Line4 = sign.getLine(3);
 
if(Line1 == "[Shop]"){
if(Line3 == "1"){
player.sendMessage(ChatColor.GRAY + "Opening Shop: " + ChatColor.GREEN + "1");
}if(Line3 == "2"){
player.sendMessage(ChatColor.GRAY + "Opening Shop: " + ChatColor.GREEN + "2");
}if(Line3 == "3"){
player.sendMessage(ChatColor.GRAY + "Opening Shop: " + ChatColor.GREEN + "3");
}if(Line3 == "4"){
player.sendMessage(ChatColor.GRAY + "Opening Shop: " + ChatColor.GREEN + "4");
}if(Line3 == "5"){
player.sendMessage(ChatColor.GRAY + "Opening Shop: " + ChatColor.GREEN + "5");
}if(Line3 == "6"){
player.sendMessage(ChatColor.GRAY + "Opening Shop: " + ChatColor.GREEN + "6");
}if(Line3 == "7"){
player.sendMessage(ChatColor.GRAY + "Opening Shop: " + ChatColor.GREEN + "7");
}if(Line3 == "8"){
player.sendMessage(ChatColor.GRAY + "Opening Shop: " + ChatColor.GREEN + "8");
}if(Line3 == "9"){
player.sendMessage(ChatColor.GRAY + "Opening Shop: " + ChatColor.GREEN + "9");
}
}
}
}
}

 

In line 6 try "instanceof" instead ==

 

KanTe

Nope, that's not an issue.

TheMcScavenger

Put in a few debug messages to see what is being called.

Perhaps you have not registered your Listener?

 

Put in a few debug messages to see what is being called.
??

Perhaps you have not registered your Listener?
Haha, I have. I've made that mistake before

 

Try on line 7
Sign sign = (Sign) clickedblock.getState();

 

No, that didn't work either

After some error searching, I found a number of mistakes. All fixed, and now it works:

Code:java

if(clickedblock.getTypeId() == Material.SIGN.getId() || clickedblock.getTypeId() == Material.SIGN_POST.getId()){

Well, I was clicking a sign on the wall, so it should've been Material.WALL_SIGN.getId()... I feel
like such a noob right now

Code:java

if(Line1 == "[Shop]"){
                    if(Line3 == "1"){
                        player.sendMessage(ChatColor.GRAY + "Opening Shop: " + ChatColor.GREEN + "1");
                    }

I used ==, which doesn't work with strings. I had to use .equals() to get it to work:

Code:java

if(Line1.equals("[Shop]")){
                    if(Line3.equals("1")){
                        player.sendMessage(ChatColor.GRAY + "Opening Shop: " + ChatColor.GREEN + "1");
                    }

Thanks for everyones help!

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

TheMcScavenger It won't really make a difference but it would be better to use getType() and the Material.SIGN enum instead of getting the id of the sign through the Material enum. Or you could just do
getTypeId() == 323 || 68 || 63

Sorry for bad code, in on my phone

 

I actually had that before, but when it didn't work, I went on a rampage and changed about all the lines in the code. I guess I could change it back... But I probably won't