Set players to teams randomly

Aight, Hello y'all!

First off, I am new to Java and teaching myself, and I am trying to create a plugin for my server.
I need some help however as I do not know what to do...
And this is where all of you super smart ppl come in to save the day!

Now what I am trying to do is as the title says, upon the use of the command /join, I wish to set that player to a random team. Either Blue or Red, I will have multiple worlds and some may have more than those two teams; ie - Yellow, Green, Blue, Red.

So first, how do I get it to set the player, upon the use of the command, to one of the teams?
And how can I set different teams per world?

Edit: Or how to setup the teams upon the game starting?

Here is my code:

Code:java

package me.x17Andrew71x.EFPM;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class PlayerJoinTeam {
 
public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
Player player = (Player)sender;
if(!player.hasPermission("efpm.join")){
player.sendMessage(ChatColor.RED + "You do not have the required permissions to do this.");
return true;
} else if(cmd.getLabel().equalsIgnoreCase("join")){
 
}
return false;
}
}

Thanks in advance!

 

To really do it random you could do this:

Code:java

Random random = new Random();
boolean value = random.nextBoolean();
if(value == true) {
    // put him team red or whatever
} else {
    // put him in team blue or whatever
}

 

EcMiner already answered your question, but there is a problem with your code. Your class must extend JavaPlugin.

Code:

public class PlayerJoinTeam extends JavaPlugin {

And don't forget to specify it in your plugin.yml!

 

First create a list

Code:

List<Player> blue = new ArrayList<Player>();
List<Player> red = new ArrayList<Player>();

Then use this method instead of randomizing. So that the teams are even.

Code:

if(blue.length >= red.length) {
    blue.add(player);
} else if(red.length <= blue.team) {
    red.add(player);
}

Should be something like that. Hope this helps

 

My OCD wishes to point out that if the teams are equal that gives one priority. I'd randomize the team in the case of both being equal so I could sleep at night

 

Don't store Player instances!

 

microgeek
Because the people who say "Don't store Player instances!" are annoying and want attention. XD

Cons about not storing Player instances: YOU CAN'T DO ANYTHING ABOUT THE PLAYER EASILY
Pros: IT'S FREAKING EASY TO DO ANYTHING WITH THE PLAYER

 

T3h Cr33p3r
xXSilentYoshiXx
It causes memory leaks, because the VM's Garbage Collector cannot destroy Object instances that reference the Player's instance.
http://javarevisited.blogspot.com/2011/04/garbage-collection-in-java.html

Just make a simple wrapper class;

Code:

class SafePlayer {
  private String playerName;
  public SafePlayer(String playerName) {
    this.playerName = playerName;
  }
 
  public Player getPlayer() {
    //might be wrong, I just typed this up
    return Bukkit.getPlayer(playerName);
  }
 
}

 

microgeek
I like how you linked them to some random garbage collection article that; without any insight into how the Player object is instanced, gives you absolutely no insight into the problem you're addressing.

 

There have been countless posts on the problem, I linked to the article, hoping people would educate themselves on how the VM's GC works.

T3h Cr33p3r
Bukkit.getServer().getPlayer() should work fine.

What errors?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Okay so, this is what I got now, but it first off, doesn't look right to even me and I dont know really what I'm doing. Also, it gives me this error that I cannot resolve:

Code:

package me.x17Andrew71x.EFPM;
 
import java.util.ArrayList;
import java.util.List;
import java.util.Random;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
 
public class PlayerJoinTeam {
   
    List<Player> blue = new ArrayList<Player>();
    List<Player> red = new ArrayList<Player>();
    List<Player> waiting = new ArrayList<Player>();
    Random rand = new Random();
 
    public boolean onCommand(CommandSender sender, Command cmd, String CommandLabel, String[] args){
        Player player = (Player)sender;
        if(!player.hasPermission("efpm.join")){
            player.sendMessage(ChatColor.RED + "You do not have the required permissions to do this.");
            return true;
        } else if(cmd.getLabel().equalsIgnoreCase("join")){
            if (waiting.size() == 0) {
                waiting.add(player);
            } else {
                Player player2 = waiting.get(0);
                if (rand.nextBoolean()) {
                    red.add(player.getName());
                    blue.add(player2.getName());
                } else {
                    blue.add(player.getName());
                    red.add(player2.getName());
                }
            }
       
        }
        return false;
    }
}

 

Honestly, you could store player instances, but it's highly recommended that you don't. If you don't even know what an instance is, then you should really just store the player's name.


The reason you should store the name was already explained above. It's really not difficult to retrieve, and can be done in 3 lines or less from the built-in method in Bukkit 'getPlayer()'

Everyone always complains about it, but it's really your choice - would you rather have a buggy, memory-leaking plugin or a normal one? -.-