"Unknown command" - Plugin commands not working

My plugin is not recognising any commands I put into the server; it simply emits the "Unknown Command" text in chat.

I have attempted to use a CommandExecutor but I have stopped due to:
A: I don't quite understand how they are implemented into my plugins.
B: It crashes whenever I call on an executor in my main class file.

I will post the error log I get with CommandExecutors tomorrow morning.
Thanks for the help, Firemx.

Main class:

Code:java

package invincibility;
 
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.player.PlayerMoveEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class AfkInvincibility extends JavaPlugin
{
    boolean Wait = true;
    public final Logger logger = Logger.getLogger("Minecraft");
    private void interrupt() {   
    }
 
    public void onEnable()
    {
        logger.info("AFK INVINCIBILITY ENABLED");
        getConfig().options().copyDefaults();
        saveConfig();
    }
 
    public void onDisable()
    {
        logger.info("AFK INVINCIBILITY DISABLED");
    }
    public void onPlayerMove (PlayerMoveEvent evt)  {
        if (Wait = true){
            interrupt();
            Wait = false;
        }
        }
    public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String label, String[] args)
    {
        if(cmd.getName().equalsIgnoreCase("AFKI"))
        {
            if (args.length > 1)
            {
                sender.sendMessage(ChatColor.RED + "Incorrect command syntax");
            }
            else
            {
                if(args.length == 0)
                {
                    sender.sendMessage(ChatColor.BLUE + "AFK Invincibility disabled.");
                    Player player = (Player) sender;
 
                    player.setWalkSpeed(1);
                    player.setFlying(false);
                    player.setNoDamageTicks(0);
                }
                else
                {
                    if(args[0].equalsIgnoreCase("on"))
                    {
                        if(!(sender instanceof Player))
                        {
                            sender.sendMessage(ChatColor.RED + "This command can only be used by players.");
                        }
                        else
                        {
                            int WaitTime;
                            WaitTime = getConfig().getInt("Wait Time:", 30);
                            sender.sendMessage(ChatColor.BLUE + "AFK wait timer activated, moving will cause the timer to reset. (" + WaitTime + ")");
                            Wait = true;
                            try {
                                Thread.sleep(WaitTime);
                            } catch(InterruptedException ex) {
                                Thread.currentThread().interrupt();
                            }
                            Wait = false;
                            sender.sendMessage(ChatColor.BLUE + "AFK Invincibility activated, type /awayfromkeyboard to reset status.");
                            Player player = (Player) sender;
 
                            player.setFlying(true);
                            player.setWalkSpeed(0);
                            player.setNoDamageTicks(-1);
                        }
                    }
                    else
                    {
                        sender.sendMessage(ChatColor.RED + "Unknown Arguement");
                    }
                }
                return true;
 
            }
 
            return false;
        }
        return false;
    }
}

Plugin.yml:

Code:

name: AFK Invincibility
main: invincibility.AfkInvincibility
version: 1.0
Description: Provides an AFK Invincibility command.
Commands:
  AFKI:
    description: Disables AFK Invincibility.
    usage: /AFKI
    permission: AFKInvincibility.AFKI
    permission-message: You don't have permission to access this command.
  AFKI on:
    description: Enables counter towards AFK Invincibility.
    usage: /AFKI on
    permission: AFKInvincibility.AFKI.on
    permission-message: You don't have permission to access this command.

 

When you run it without the command executors functions do you get an error?

 

Hello Firemx,
you cant have an space in a command name "AFKI on".

 

Make sure you putted the command in the plugin.yml

 

in the onEnable() don't you need to define getCommand("command here").setExecutor(this);

 

on the check if the first argument is on, you didn't check if there was typed a first argument

 

I infact, have.

Code:java

  if (args.length > 1)
            {
                sender.sendMessage(ChatColor.RED + "Incorrect command syntax");
            }
            else
            {
                if(args.length == 0)
                {
                    sender.sendMessage(ChatColor.BLUE + "AFK Invincibility disabled.");
                    Player player = (Player) sender;
 
                    player.setWalkSpeed(1);
                    player.setFlying(false);
                    player.setNoDamageTicks(0);
                }
                else
                {
                    if(args[0].equalsIgnoreCase("on"))

The server gives me an error when I do that.

It's in there. ^_^

This isn't the problem for now, but i'll definitely keep this in mind.

The very opposite.

 

type: /pl
check if the plugin is on the list.
if dont have error try in plugin.yml to change that:
from:

Code:

Commands:
  AFKI:

to:

Code:

commands:
  AFKI:

maybe the capital C is the reson..

 

The plugin is on the list, I'll check the C now.

Edit: It worked, but now it's just sending back: "/AFKI" whenever I attempt a command in my code. (/AFKI and /AFKI on)

 

That's what I thought, as well as needing to getCommand("cmd").setExecutor(this) ?
What error do you get when you register the command like this in onEnable()?

 

Give me a second, I will check. (This post approval thing is getting annoying, when does it shut off?)

Edit: Without any reference to an external class nothing changes.

getCommand("AFKI").setExecutor(this);

 

try to change in plugin.yml the usage of the command...
the usage of the command its the same as the command so maybe its sending you the usage...
if its actually sending you the usage so thats says that its think that you write the command with now enogh arguments...

 

I know for certain the usage part of the Plugin.yml isn't used by Bukkit.

I've tested out some possible solutions, none fixed it...

The code is still displaying "/AFKI" whenever the command is used.

New Code:

Code:java

package invincibility;
 
import java.util.logging.Logger;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.player.PlayerMoveEvent;
import org.bukkit.plugin.java.JavaPlugin;
 
public class AfkInvincibility extends JavaPlugin
{
boolean Wait = true;
public final Logger logger = Logger.getLogger("Minecraft");
private void interrupt() {
}
 
public void onEnable()
{
logger.info("AFK INVINCIBILITY ENABLED");
getConfig().options().copyDefaults();
saveConfig();
getCommand("afki").setExecutor(this);
}
 
public void onDisable()
{
logger.info("AFK INVINCIBILITY DISABLED");
}
@EventHandler
public void onPlayerMove (PlayerMoveEvent evt) {
if (Wait = true){
interrupt();
Wait = false;
}
}
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String label, String[] args)
{
if(cmd.getName().equalsIgnoreCase("afki"))
{
if (args.length > 1)
{
sender.sendMessage(ChatColor.RED + "Incorrect command syntax");
}
else
{
if(args.length == 0)
{
sender.sendMessage(ChatColor.BLUE + "AFK Invincibility disabled.");
Player player = (Player) sender;
 
player.setWalkSpeed(1);
player.setFlying(false);
player.setNoDamageTicks(0);
}
else
{
if(args[0].equalsIgnoreCase("on"))
{
if(!(sender instanceof Player))
{
sender.sendMessage(ChatColor.RED + "This command can only be used by players.");
}
else
{
int WaitTime;
WaitTime = getConfig().getInt("Wait Time:", 30);
sender.sendMessage(ChatColor.BLUE + "AFK wait timer activated, moving will cause the timer to reset. (" + WaitTime + ")");
Wait = true;
try {
Thread.sleep(WaitTime);
} catch(InterruptedException ex) {
Thread.currentThread().interrupt();
}
Wait = false;
sender.sendMessage(ChatColor.BLUE + "AFK Invincibility activated, type /awayfromkeyboard to reset status.");
Player player = (Player) sender;
 
player.setFlying(true);
player.setWalkSpeed(0);
player.setNoDamageTicks(-1);
}
}
else
{
sender.sendMessage(ChatColor.RED + "Unknown Arguement");
}
}
return true;
 
}
 
return false;
}
return false;
}
}

Plugin.yml:

Code:

name: AFK Invincibility
main: invincibility.AfkInvincibility
version: 1.0
Description: Provides an AFK Invincibility command.
commands:
  afki:
    description: Disables AFK Invincibility.
    usage: /AFKI
    permission: AFKInvincibility.AFKI
    permission-message: You don't have permission to access this command.
#  on:
#    description: Enables counter towards AFK Invincibility.
#    usage: /AFKI on
#    permission: AFKInvincibility.AFKI.on
#    permission-message: You don't have permission to access this command.

Bump?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Firemx no you didn't, you only checked if the arguments where 0, or bigger than 1

 

I don't need to check.

If it's not 0 and it's not anything higher than 1 it's obviously 1.

 

You're class with the "onCommand" needs to implement "CommandExecutor" like this:

Code:java

public class AfkInvincibility extends JavaPlugin implements CommandExecutor

Also, if you set the CommandExecutor, you do NOT need to check if cmd equals "AFKI"
Additionally, don't let your thread sleep. This won't allow other players to use the command. (You could make a new thread so)

It would be much better to have a HashMap with all AFK-Players.
Then, start with Bukkit a "repeating task" that ticks every second (you can define how often it should ticks)
In that, you can decrease a players "cooldown".
And add players to that hashmap when they type "/afki"

(Sry if I missunderstood something in your code.)

Just ask if you want to know something

EDIT:
To check if a player moves or something you need to use listeners. So if a player does something and he is in the hashmap, reset his timer.

 

JavaPlugin already implements CommandExecutor. No need to add it manually. Also, you do not need to add it as CommandExecutor. The onCommand() method of the main class is called for every command. That's why you need to check the command label.

Thread.sleep(WaitTime); causes the whole server to wait. Don't use it.

The only reason, you did not note this yet is, that your wait time is 30 milliseconds.

getConfig().getInt("Wait Time:", 30);
"Wait Time:" is no valid config node. Use something like "settings.waittime" for:

Code:

settings:
  waittime: 30

Do not use spaces!

Your main problem:

Code:

    usage: /AFKI

Whnever onCommand returns false, bukkit prints the "usage" message because return false indicates, that the player failed to use the command properly.

Code:

    @EventHandler
    public void onPlayerMove (PlayerMoveEvent evt) {

Will never be fired. You have to make a Listener and register it.
http://wiki.bukkit.org/Event_API_Reference

 

Oh I'm sorry. Thank you AmShaegar!

 

I know about the hashmaps, though I have yet to fork that code over to them. (Thanks to everyone who did mention it though. )

So why would bukkit be returning false in the first place?

 

Why does your onCommand have 2 String parameters? The overridden onCommand looks like this:

Code:java

@Override
public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {

 

ughh..... *hides* First plugin? :3

Either way, I still can't get it to not return false.

 

could you repost your current code?

 

It's still the same for now, i'm not at my computer.

 

Oh. If you use the correct onCommands method your error should be solved.

 

Wait, what do you mean? What exact part of the method is incorrect?

Sorry for being a bit of a nub.

 

compare:

Code:

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args)
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String label, String[] args)

In other words: Your method(2nd one) will never be called. So internally you will always get false. This is because your second String label parameter prevents onCommand from being overridden rather than just being added.

 

It appears you were right.

Now to fix my other countless problems with my code...

Could you possibly explain Hashmaps to me? I get the general concept and how to use them for basic operations but how would I make a counter inside their Hash's?

 

Do not make a counter. Save timestamps. A basic use of HashMaps would look like this:

Code:java

HashMap<String, Long> startTimes = new HashMap<String, Long>;
 
// Check if player is in the timeframe
long start = startTimes.get(player.getName()),
    end = start + duration; // duration in ms. E.g. 30*1000 = 30 seconds
if(end < System.currentTimeMillis()) { // means if current time is after the end
    // do something that starts the countdown
    startTimes.put(player.getName(), System.currentTimeMillis());
} else {
    long timeToWait = end - System.currentTimeMillis(); // in ms
    // print time to wait
}
 

This is kind of a cooldown system. You could also use it to start a reapeating task that checks all times every second to do something if time is up.

 

Also, how would I call on Player.getName() outside of an onCommand method?

It appears to need the variable "Player" which I have specified inside onCommand due to its dependency on the "Sender" arg of the onCommand method.

 

Where outside?

In another method: Pass th player reference to that method.

Code:

public void method(Player player)

In a countdown where you loop throug all entries:

Code:java

for(Entry<String, Long> e : startTimes.entrySet()) {
    String name = e.getKey();
    Long time = e.getValue();
    Player player = Bukkit.getPlayerExact(name);
}