[LIB] [1.7] Remote entities - Next generation NPC library [No support]

TomShar · Apr 4, 2013

kumpelblase2 said: ↑
1.5 is out!
Code:
Version 1.5:
- Entity will now have a metadatavalue representing the remote entity
- Renamed and moved some internal classes such as DesireSelector and PathfinderGoalSelectorHelper
- Changed action desires to target desires
- Fixed serialization in some classes
- Added  ability to override attacking mechanics in some desires
- Added base for OneTimeDesires
- Updated to 1.5.1
- Added events for starting and stopping desires
- Small other additions
Download see first post!

EDIT: Javadocs are up! Also updated the example in the first post to reflect recent changes.
Click to expand...
Awesome, thanks!

so is it possible to do things like making zombies break and place blocks?

Forge_User_58953186 · Apr 4, 2013

TomShar said: ↑

so is it possible to do things like making zombies break and place blocks?
Click to expand...

technically yes.

TomShar · Apr 4, 2013

kumpelblase2 said: ↑

technically yes.
Click to expand...

'technically'?

Forge_User_58953186 · Apr 4, 2013

TomShar said: ↑

'technically'?
Click to expand...

It depends on how you want it exactly. Sure, you can let zombies walk around and destroy every grass block they see. But you can't - yet - let them move a path ignoring all obstacles and destroy them on their way. I mean, there'll probably be a way to even achieve that but some things are much likely still not really possible.

TeeePeee · Apr 4, 2013

Last question - I promise xD

Is there a way to restore mob speeds to normal after using RemoteEntity.setSpeed(...)? or must I determine the normal speed of the mob and set it to that?

MylesIsCool · Apr 4, 2013

Is it possible to add back compatibility (for future versions), because as there is not a recommended build etc it might not work for some people as they might be using older 1.5.1 versions.

Otherwise: Great library!

Forge_User_58953186 · Apr 5, 2013

TeeePeee said: ↑

Last question - I promise xD

Is there a way to restore mob speeds to normal after using RemoteEntity.setSpeed(...)? or must I determine the normal speed of the mob and set it to that?
Click to expand...

As easy as that:
Code:
entity.setSpeed(DefaultEntitySpeed.<the_entity_type>);
MylesIsCool said: ↑

Is it possible to add back compatibility (for future versions), because as there is not a recommended build etc it might not work for some people as they might be using older 1.5.1 versions.
Click to expand...

I'd like to have that yes, but it's too much nms code to do so.

hebrecht · Apr 5, 2013

I'm using this library to create a 'clone' of a player on a server by creating a RemotePlayerEntity. I'm catching the Bukkit PlayerMovementEvent and using that location information to have the 'clone' mirror the movement of the player. At the moment the 'clone' moves exactly like the player, it changes it's yaw and pitch to mirror the player's yaw and pitch. The only problem I have is making the clone look in the same direction as the player is looking.

The code I am using is as follows:
Code:
private Player player;
private RemoteEntity ghost;
private RemotePlayerEntity rc_ghost;
private double offset = 2.0;
 
public void createGhostOfPlayer(Player player) {
    if (ghost == null) {
        this.player = player;
        Location loc = player.getLocation();
        this.ghost = npcManager.createNamedEntity(RemoteEntityType.Human, loc, "Ghost_of_"+player.getDisplayName());
        this.ghost.getMind().clearMovementDesires();
        this.ghost.getMind().clearTargetingDesires();
        this.ghost.getMind().clearBehaviours();
        rc_ghost = (RemotePlayerEntity)this.ghost.getHandle();
        if (rc_ghost != null) {
            rc_ghost.copyTo((EntityHuman)this.ghost.getHandle(),true);
            rc_ghost.setPositionRotation(loc.getX()+offset, loc.getY(), loc.getZ(), loc.getPitch(), loc.getYaw() );       
        }
    }
}
 
public boolean moveGhost(Location from, Location to){
    if (ghost != null) {
        rc_ghost.setPositionRotation(to.getX()+offset, to.getY(), to.getZ(), to.getYaw(), to.getPitch() );
           
        ghost.setYaw(to.getYaw(),true);   
        ghost.setPitch(to.getPitch());
        ghost.lookAt(to);
        ghost.getMind().fixYawAt(to.getYaw());
        ghost.getMind().fixPitchAt(to.getPitch());
           
        return true;
    }
    return false;
}
I manage to briefly make the clone look in the same direction as the player, but it appears as if some other process is causing the head to rotate back to some yaw position (note that the pitch of the clone's head is not affected). I've initially thought that the Mind of the RemoteEntity might be causing this (hence disabling all behaviour when the clone is created), but I still get the head rotating back.

Do I need to get the location a player is looking at and set the clones look location using EntityLiving's ControllerLook member? The problem with this is that there does not seem to be a method for getting the exact direction a player is looking.

Any suggestions are more than welcome.

Forge_User_58953186 · Apr 5, 2013

Another update (1.5.1)!

Changes:

Code:

- Fixed some desire types
- Fixed default desires for cave spider
- Updated wrong desire logics (These were a lot)

MylesIsCool · Apr 5, 2013

Hi there,

I've got my entity to spawn at players location on command but it seems that it spawns at spawn then takes up to a minute to goto the location. Is this a problem my end or the plugin?

(Edit: Looks like this is only a human bug, with enderdragon etc works nicely )

Thanks

hebrecht · Apr 5, 2013

I managed to solve the problem of head rotation of Remote Entities. Basically the solution was that RemoteEntities does not have functionality to fix the head yaw rotation in a similar manner as the entity pitch and entity yaw is fixed using RemoteEntity.setFixedPitch and RemoteEntity.setFixedYaw. I've added some methods to RemoteEntities.java, RemoteBaseEntity.java and Mind.java to address this issue.

How can I go about submitting the proposed changes for inclusion in the next update?

MylesIsCool · Apr 5, 2013

hebrecht said: ↑

I managed to solve the problem of head rotation of Remote Entities. Basically the solution was that RemoteEntities does not have functionality to fix the head yaw rotation in a similar manner as the entity pitch and entity yaw is fixed using RemoteEntity.setFixedPitch and RemoteEntity.setFixedYaw. I've added some methods to RemoteEntities.java, RemoteBaseEntity.java and Mind.java to address this issue.

How can I go about submitting the proposed changes for inclusion in the next update?
Click to expand...

I believe you need to fork it on github then submit a pull request

JeroenV · Apr 5, 2013

I've been trying this library out for a few hours now and first of all I'd like to say "Great job on making this". However I am a tad confused as to why some Desires/Behaviours are acting a bit weird, but it's most likely just because of my doing.

Here are my notifications of which I'd like to know why this is happening:

1. I noticed that MoveToLocation desire only worked with zombies.
2. When spawning in a NamedEntity they would first be invisible for about 2 minutes and then they magically appear.
3. After using an array of behaviours and Desires and testing them out for a while, it gave me a few question:
a) When using DesireKillTarget(re,(LivingEntity) e.getPlayer()),1); the entity would move a maximum of about 3 blocks and after hitting me once it would stop.
b) When using DesireMoveToTarget I figured I would have to set the target first so I tried using DesireFindNearestTarget(re,Player.class,5f,false,5) but nothing happened.
c) When using DamageBehavior I noticed that it didn't trigger when I hit the entity.

All I really want to do is let a group of zombies walk from one location to another and when encountering 'certain' players in their path they would attack them. After that they continue to their destination.

Thanks in advance!

Greets,
Jero

Forge_User_58953186 · Apr 5, 2013

hebrecht : Thanks for the pr. I assume that your issue is solved with that or am I wrong?

JeroenV : 1. Just tested, player and spider move to correct location. It might be because other desires were overriding that desire which won't let it execute. Or is it the only desire?
2. Also checked a second ago, works fine. I also wouldn't know why, because the spawning did not change in recent minecraft versions.
3. a) Fixed in >Fixed DesireKillTarget and DesireAttackOnCollide not working properly.
b) will be looking into it later.
c) Fixed in >Fixed damage behavior not getting executed properly.

TeeePeee · Apr 5, 2013

Hm... When I try to use RemoteZombie.copyInventory(Player, false) I get an IllegalArgumentException, expecting 27 or less... When I use RemoteZombie.getInventory().setContents(Player.getInventory().getContents()) I get the same error. All I'm trying to do is make a zombie with the same inventory/equipment as a player... Thoughts?

hebrecht · Apr 5, 2013

kumpelblase2 Thanks for accepting the pr. Yes, that did solve my problem. My clones are now exactly mirror the movement of my players

Forge_User_58953186 · Apr 6, 2013

hebrecht : Good to heart that!

TeeePeee : For the time being, just add the inventory feature with a size of 36. I'll push out a fix for the default size later.

MylesIsCool · Apr 6, 2013

This is my code:

Code:

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
        EntityManager manager = RemoteEntities.createManager(this);
        Player p = (Player) sender;
        RemoteEntity entity = manager.createNamedEntity(RemoteEntityType.Human, p.getLocation(), "PVP_" + p.getName(), false);
        entity.getBukkitEntity().teleport(p.getLocation());
        try {
            Mind mind = entity.getMind();
            mind.addMovementDesire(new DesireSwim(entity), 0);
            mind.addMovementDesire(new DesireDestroyDoor(entity, false), 1);
            mind.addMovementDesire(new DesireAttackOnCollide(entity, LivingEntity.class, false), 2);
            mind.addMovementDesire(new DesireMoveTowardsRestriction(entity), 4);
            mind.addMovementDesire(new DesireMoveThroughVillage(entity, false), 5);
           
            mind.addMovementDesire(new DesireWanderAround(entity), 6);
            mind.addMovementDesire(new DesireLookAtNearest(entity, Player.class, 8), 7);
            mind.addMovementDesire(new DesireLookRandomly(entity), 7);
            mind.addTargetingDesire(new DesireFindAttackingTarget(entity, 16, false, false), 1);
            mind.addTargetingDesire(new DesireFindNearestTarget(entity, LivingEntity.class, 16, false, true, 0), 2);
            //Bukkit.getServer().dispatchCommand(((Player) entity.getBukkitEntity()), "aux " + args[0]);
        } catch (Exception e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
        }
        return true;
    }

PS: It's testing code, yes I know the sender might not be a player

But it takes upto 2 minutes for the player to goto the players location and also I am running the latest jenkins build.
Please could you have a look into this.

CreeperShift · Apr 6, 2013

kumpelblase2

I have a question:

I was going through the javadocs and I'm wondering if you can somehow force the player npc to appear as he is sleeping without the bed:

enterBed

public boolean enterBed(org.bukkit.Location inLocation)
Tries to place the npc in a bed at given location.

Parameters:
inLocation - Location the bed is present.
Returns:
True if it was possible, false if not
Click to expand...

As this implies you need the bed for it :/

Forge_User_58953186 · Apr 6, 2013

MylesIsCool took your exact code and I put it in a testing plugin using onJoinEvent and works fine like it should. No issues. Which craftbukkit build are you using?

CreeperShift Probably only through sending packets individually.

CreeperShift · Apr 6, 2013

kumpelblase2 said: ↑

CreeperShift Probably only through sending packets individually.
Click to expand...

Dang, kay I'll try that then. Thanks for the quick reply tho!

Hoolean · Apr 7, 2013

kumpelblase2 said: ↑
Remote Entities

Hey everyone!

After about two weeks of work, I managed to finish my NPC library. It was made with the idea of being able to modify the entities in any possible way. So I started from scratch, made my plans and now I'm here with the first version. It's only compatible with 1.5.1, not with any other version (see earlier releases for other version compatibility).

So what is it capable of?
- Use any entity as a npc
- Customize speed
- Change and create own goals/desires
- Cross-plugin interactivity
- Make your own behaviors

What do I need as a developer?
Either: download it (see link at the end) and add it just like you'd do with craftbukkit/bukkit.
Or (using maven):
Show Spoiler Hide Spoiler
Code:
<repositories>
    ...
    <repository>
        <id>remoteentities-repo</id>
        <url>http://repo.infinityblade.de/remoteentities/releases</url>
    </repository>
    ...
</repositories>
 
...
 
<dependencies>
    ...
    <dependency>
        <groupId>de.kumpelblase2</groupId>
        <artifactId>remoteentities</artifactId>
        <version>1.5</version>
    </dependency>
    ...
</dependencies>
and maven will do the rest (don't forget to update the version!).
You can also use this url when you also want to get the snapshots:
Code:
http://repo.infinityblade.de/remoteentities/snapshots
What do users of my plugin need?
They also need the plugin, just like Vault. See 'download' below.

Alright, so how do I get started?
First, add the plugin to your (soft)dependencies in your plugin.yml:
Code:
depend: [RemoteEntities]
Now lets get into the code:
Code:java
public void onEnable()
{
//First we need an instance of the manager, which keeps track of your entities
EntityManager manager = RemoteEntities.createManager(this);
//Using the manager we create a new Zombie npc at the spawn location, but we won't setup the standard desires/goals
RemoteEntity entity = manager.createEntity(RemoteEntity.Zombie, Bukkit.getWorld("world").getSpawnLocation(), false);
//We don't want him to move so we make him stationary
entity.setStationary(true);
//Now we want him to look at the nearest player. This desire has a priority of 1 (the higher the better).
//Since we don't have any other desires 1 is totally fine.
//Note that when you have more than one desire with the same priority, both could get executed, but they'd need a different type (e.g. looking and moving)
//This does not get executed all the time. It might just get executed but he might take a break for 2 seconds after that. It's random.
entity.getMind().addMovementDesire(new DesireLookAtNearest(entity, Player.class, 8F), 1);
//When a player interacts with him, we want him to tell something to the player.
//I make an anonymous class here, but you can create a whole new class if you want to
//but it needs to extend InteractBehaviour
entity.getMind().addBehaviour(new InteractBehaviour(entity)
{
@Override
public void onInteract(Player inPlayer)
{
inPlayer.sendMessage("Hello " + inPlayer.getName() + "!");
}
});
}
So let me explain things further:
- EntityManager: The entity manager creates, removes and generally keeps track of all your entities.

- RemoteEntity: This is the base instance of the entity. Each entity has a specific subclass (e.g. RemoteZombie) which might enables more functionality for the entity (e.g. let a creeper explode).

- Mind: Yes, entities do have a mind in my library. The mind essentially controls or executes every action of the entity. Like which desire gets executed, should a behavior get fired. Moreover, it contains all the features of the entity.

- Desire: A desire is something that the entity wants to do. For example, a zombie wants to attack the nearest player (DesireAttackNearest). You can create your own ones or just build on top of the existing ones. (Preset desires see this)

- Behavior: Behaviors control what an entity should do on a specific event, when a player touches them for instance. Again, you can create your own ones here.

- Features: Giving a zombie a taming feature would allow you to use the zombie as a pet. So features give you functionality that's normally not available for the entity. (Preset features see this)

That seems interesting. Where can I find javadocs or something like that?
JavaDocs can be found: HERE
Source is available: HERE
Jenkins: HERE

Still having questions?
Then go ahead and ask! I haven't covered everything here, so it's totally ok to ask.

Last words
Alright, I'm not the best writer so I hope I wrote everything as clear as possible. Like I said, feel free to ask if something isn't clear enough.
When you have a suggestion, you shouldn't wait and just tell me, it won't hurt you.

Download
Version 1.5.1

Changelog
Code:
Version 1.5.1:
- Fixed some desire types
- Fixed default desires for cave spider
- Updated wrong desire logics (These were a lot)
 
Version 1.5:
- Entity will now have a metadatavalue representing the remote entity
- Renamed and moved some internal classes such as DesireSelector and PathfinderGoalSelectorHelper
- Changed action desires to target desires
- Fixed serialization in some classes
- Added  ability to override attacking mechanics in some desires
- Added base for OneTimeDesires
- Updated to 1.5.1
- Added events for starting and stopping desires
- Small other additions
 
Version 1.4:
- Added an api for implementing persistence
- getActionDesires() and getMovementDesires() now returns a list of desire items so you can also get the priority
- Fixed npe when settings using custom max health in createentitycontext
- Fixed issues with copyInventory
- Changed desire constructors to also accept bukkit classes. You won't notice this right away because it will still work like the way it used to but with the addition that you can also pass in common bukkit classes.
- Enhanced entity spawning and respawning while loading/unloading chunks.
- Fixed createEntityFromExisting not setting up default desires
- Updated with (craft)bukkit -> 1.4.7
 
Version 1.3:
- Updated for Craftbukkit 1.4.5-R1.0.
- Removed EntityEquipment feature.
- Hopefully fixed concurrent exception.
- Throwing some exceptions when using Remoteentities when it's not enabled.
 
Version 1.2:
- Updated with 1.4.5
- Fixed melee
- Fixed many NPEs
- No longer interferes with other plugins using the entity type enum
- Fixed standard goals for mushroom entity
- Fixed entities not getting respawned on chunck reload
- Fixed RemoteEntityInteractEvent not getting fired
- Added new way for creating entities
 
Version 1.1.1:
- Fixed some entities not updating their mind
 
Version 1.1:
- Fixed NPEs crashing the server
- Fixed some issues with custom entity types
- Fixed many entities ignoring stationary and push status
 
Version 1.0:
- First release
Plugins/Servers using it
Mineblown.com (the main reason why I created it.)

That's it,
have fun!
~kumpelblase2.
Click to expand...
Wow that looks awesome

MylesIsCool · Apr 7, 2013

kumpelblase2 said: ↑

MylesIsCool took your exact code and I put it in a testing plugin using onJoinEvent and works fine like it should. No issues. Which craftbukkit build are you using?

CreeperShift Probably only through sending packets individually.
Click to expand...

Build: craftbukkit-1.5.1-R0.1-20130323.060235-13.jar

Hoolean · Apr 7, 2013

kumpelblase2

Is it possible to get the Default desires of a RemoteEntity (say a skeleton) and add it to another RemoteEntity? It'd be interesting to have zombies that behaved like Creepers or Skeletons that behaved like zombies

Forge_User_58953186 · Apr 7, 2013

MylesIsCool I can't seem to be able to reproduce it even with that exact version. Might something else "block" the entity from being spawned? Or maybe delays the packet from being sent?

MrBluebear3 Currently not, but I'll do that.

Hoolean · May 29, 2016

Thanks for the time and effort you've put into this plugin, it's a great help for a lot of us plugin developers

kumpelblase2

Error! *scream*

Code:

17:08:07 [SEVERE] Could not pass event CreatureSpawnEvent to PetChickens v1.5.1_0
org.bukkit.event.EventException
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:427)
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
    at org.bukkit.craftbukkit.v1_5_R2.event.CraftEventFactory.callCreatureSpawnEvent(CraftEventFactory.java:230)
    at net.minecraft.server.v1_5_R2.World.addEntity(World.java:925)
    at de.kumpelblase2.remoteentities.entities.RemoteBaseEntity.spawn(RemoteBaseEntity.java:269)
    at de.kumpelblase2.remoteentities.ChunkEntityLoader.queueSpawn(ChunkEntityLoader.java:135)
    at de.kumpelblase2.remoteentities.EntityManager.createEntity(EntityManager.java:136)
    at com.puffybugs.PetChickens.PetChickens.onChickenSpawn(PetChickens.java:55)
    at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:601)
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425)
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
    at org.bukkit.craftbukkit.v1_5_R2.event.CraftEventFactory.callCreatureSpawnEvent(CraftEventFactory.java:230)
    at net.minecraft.server.v1_5_R2.World.addEntity(World.java:925)
    at de.kumpelblase2.remoteentities.entities.RemoteBaseEntity.spawn(RemoteBaseEntity.java:269)
    at de.kumpelblase2.remoteentities.ChunkEntityLoader.queueSpawn(ChunkEntityLoader.java:135)
    at de.kumpelblase2.remoteentities.EntityManager.createEntity(EntityManager.java:136)
    at com.puffybugs.PetChickens.PetChickens.onChickenSpawn(PetChickens.java:55)
    at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:601)
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425)
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
    at org.bukkit.craftbukkit.v1_5_R2.event.CraftEventFactory.callCreatureSpawnEvent(CraftEventFactory.java:230)
    at net.minecraft.server.v1_5_R2.World.addEntity(World.java:925)
    at de.kumpelblase2.remoteentities.entities.RemoteBaseEntity.spawn(RemoteBaseEntity.java:269)
    at de.kumpelblase2.remoteentities.ChunkEntityLoader.queueSpawn(ChunkEntityLoader.java:135)
    at de.kumpelblase2.remoteentities.EntityManager.createEntity(EntityManager.java:136)
    at com.puffybugs.PetChickens.PetChickens.onChickenSpawn(PetChickens.java:55)
    at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:601)
    at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:425)
    at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62)
    at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:477)
    at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:462)
    at org.bukkit.craftbukkit.v1_5_R2.event.CraftEventFactory.callCreatureSpawnEvent(CraftEventFactory.java:230)
    at net.minecraft.server.v1_5_R2.World.addEntity(World.java:925)
    at de.kumpelblase2.remoteentities.entities.RemoteBaseEntity.spawn(RemoteBaseEntity.java:269)
    at de.kumpelblase2.remoteentities.ChunkEntityLoader.queueSpawn(ChunkEntityLoader.java:135)

EDIT: Just found the end of the error - it was EXTREMELY long

Code:

Caused by: java.lang.NullPointerException
    at de.kumpelblase2.remoteentities.api.thinking.goals.DesireFollowTamer.getTamer(DesireFollowTamer.java:126)
    at de.kumpelblase2.remoteentities.api.thinking.goals.DesireFollowTamer.shouldExecute(DesireFollowTamer.java:49)
    at de.kumpelblase2.remoteentities.api.thinking.DesireSelector.onUpdate(DesireSelector.java:48)
    at de.kumpelblase2.remoteentities.api.thinking.Mind.tick(Mind.java:328)
    at de.kumpelblase2.remoteentities.entities.RemoteChickenEntity.l_(RemoteChickenEntity.java:92)
    at net.minecraft.server.v1_5_R2.World.entityJoinedWorld(World.java:1356)
    at net.minecraft.server.v1_5_R2.WorldServer.entityJoinedWorld(WorldServer.java:614)
    at net.minecraft.server.v1_5_R2.World.playerJoinedWorld(World.java:1337)
    at net.minecraft.server.v1_5_R2.World.tickEntities(World.java:1225)
    at net.minecraft.server.v1_5_R2.WorldServer.tickEntities(WorldServer.java:480)
    at net.minecraft.server.v1_5_R2.MinecraftServer.r(MinecraftServer.java:560)
    ... 4 more

On my client there is quite a lot of chickens and the stack trace above repeated lines over and over until the server crashed

Here is my code:

Code:java

 
package com.puffybugs.PetChickens;
 
import org.bukkit.Material;
import org.bukkit.Server;
import org.bukkit.entity.Chicken;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.CreatureSpawnEvent;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
import de.kumpelblase2.remoteentities.EntityManager;
import de.kumpelblase2.remoteentities.RemoteEntities;
import de.kumpelblase2.remoteentities.api.RemoteEntity;
import de.kumpelblase2.remoteentities.api.RemoteEntityType;
import de.kumpelblase2.remoteentities.api.features.RemoteTamingFeature;
import de.kumpelblase2.remoteentities.api.thinking.InteractBehavior;
import de.kumpelblase2.remoteentities.api.thinking.goals.DesireFollowTamer;
import de.kumpelblase2.remoteentities.api.thinking.goals.DesireProtectOwner;
 
public class PetChickens extends JavaPlugin implements Listener{
 
Server serv;
PluginDescriptionFile pdf;
 
EntityManager manager;
 
@Override
public void onEnable() {
 
serv = getServer();
pdf = getDescription();
 
manager = RemoteEntities.createManager(this);
 
serv.getPluginManager().registerEvents(this, this);
 
getLogger().info(getName()+" version "+pdf.getVersion()+" has been enabled!");
 
}
 
@Override
public void onDisable() {
 
getLogger().info(getName()+" version "+pdf.getVersion()+" has been disabled!");
 
}
 
@EventHandler
public void onChickenSpawn(CreatureSpawnEvent event) {
 
if(event.getEntity() instanceof Chicken) {
 
RemoteEntity chicken = manager.createEntity(RemoteEntityType.Chicken, event.getLocation(), false);
 
final RemoteTamingFeature taming = new RemoteTamingFeature(chicken);
 
chicken.getFeatures().addFeature(taming);
 
try {
chicken.getMind().addMovementDesire(new DesireFollowTamer(chicken, 1, 10), 1);
} catch (Exception e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
 
try {
chicken.getMind().addTargetingDesire(new DesireProtectOwner(chicken, 10f, false), 1);
} catch (Exception e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
 
chicken.getMind().addBehaviour(new InteractBehavior(chicken) {
 
@Override
public void onInteract(Player player) {
 
if(player.getItemInHand() != null && player.getItemInHand().getType()==Material.RED_ROSE) {
 
taming.tame(player);
 
}
 
}
 
});
 
event.setCancelled(true);
 
}
 
}
 
}

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

Forge_User_58953186 · Apr 7, 2013

MrBluebear3 Spawning a RemoteEntity will trigger a CreatureSpawnEvent as well. Thus, when you replace an entity in that event, it will end in an infinite loop and eventually crash the server if you don't check if the entity is a remote entity already.
The best, and easiest, way to check if the entity is a remote entity is to do RemoteEntities.isRemoteEntity(<entity>).

Hoolean · May 29, 2016

Silly MrBluebear3 ! I probably should have thought of that

Well thanks for your help

Hmm.... Another error

Code:

20:57:43 [SEVERE] net.minecraft.server.v1_5_R2.ReportedException: Ticking entity
20:57:43 [SEVERE]    at net.minecraft.server.v1_5_R2.MinecraftServer.r(MinecraftServer.java:564)
20:57:43 [SEVERE]    at net.minecraft.server.v1_5_R2.DedicatedServer.r(DedicatedServer.java:225)
20:57:43 [SEVERE]    at net.minecraft.server.v1_5_R2.MinecraftServer.q(MinecraftServer.java:474)
20:57:43 [SEVERE]    at net.minecraft.server.v1_5_R2.MinecraftServer.run(MinecraftServer.java:407)
20:57:43 [SEVERE]    at net.minecraft.server.v1_5_R2.ThreadServerApplication.run(SourceFile:573)
20:57:43 [SEVERE] Caused by: java.lang.NullPointerException
20:57:43 [SEVERE]    at de.kumpelblase2.remoteentities.api.thinking.goals.DesireFollowTamer.getTamer(DesireFollowTamer.java:126)
20:57:43 [SEVERE]    at de.kumpelblase2.remoteentities.api.thinking.goals.DesireFollowTamer.shouldExecute(DesireFollowTamer.java:49)
20:57:43 [SEVERE]    at de.kumpelblase2.remoteentities.api.thinking.DesireSelector.onUpdate(DesireSelector.java:48)
20:57:43 [SEVERE]    at de.kumpelblase2.remoteentities.api.thinking.Mind.tick(Mind.java:328)
20:57:43 [SEVERE]    at de.kumpelblase2.remoteentities.entities.RemoteChickenEntity.l_(RemoteChickenEntity.java:92)
20:57:43 [SEVERE]    at net.minecraft.server.v1_5_R2.World.entityJoinedWorld(World.java:1356)
20:57:43 [SEVERE]    at net.minecraft.server.v1_5_R2.WorldServer.entityJoinedWorld(WorldServer.java:614)
20:57:43 [SEVERE]    at net.minecraft.server.v1_5_R2.World.playerJoinedWorld(World.java:1337)
20:57:43 [SEVERE]    at net.minecraft.server.v1_5_R2.World.tickEntities(World.java:1225)
20:57:43 [SEVERE]    at net.minecraft.server.v1_5_R2.WorldServer.tickEntities(WorldServer.java:480)
20:57:43 [SEVERE]    at net.minecraft.server.v1_5_R2.MinecraftServer.r(MinecraftServer.java:560)
20:57:43 [SEVERE]    ... 4 more
20:57:43 [SEVERE] Encountered an unexpected exception ReportedException
net.minecraft.server.v1_5_R2.ReportedException: Ticking entity
    at net.minecraft.server.v1_5_R2.MinecraftServer.r(MinecraftServer.java:564)
    at net.minecraft.server.v1_5_R2.DedicatedServer.r(DedicatedServer.java:225)
    at net.minecraft.server.v1_5_R2.MinecraftServer.q(MinecraftServer.java:474)
    at net.minecraft.server.v1_5_R2.MinecraftServer.run(MinecraftServer.java:407)
    at net.minecraft.server.v1_5_R2.ThreadServerApplication.run(SourceFile:573)
Caused by: java.lang.NullPointerException
    at de.kumpelblase2.remoteentities.api.thinking.goals.DesireFollowTamer.getTamer(DesireFollowTamer.java:126)
    at de.kumpelblase2.remoteentities.api.thinking.goals.DesireFollowTamer.shouldExecute(DesireFollowTamer.java:49)
    at de.kumpelblase2.remoteentities.api.thinking.DesireSelector.onUpdate(DesireSelector.java:48)
    at de.kumpelblase2.remoteentities.api.thinking.Mind.tick(Mind.java:328)
    at de.kumpelblase2.remoteentities.entities.RemoteChickenEntity.l_(RemoteChickenEntity.java:92)
    at net.minecraft.server.v1_5_R2.World.entityJoinedWorld(World.java:1356)
    at net.minecraft.server.v1_5_R2.WorldServer.entityJoinedWorld(WorldServer.java:614)
    at net.minecraft.server.v1_5_R2.World.playerJoinedWorld(World.java:1337)
    at net.minecraft.server.v1_5_R2.World.tickEntities(World.java:1225)
    at net.minecraft.server.v1_5_R2.WorldServer.tickEntities(WorldServer.java:480)
    at net.minecraft.server.v1_5_R2.MinecraftServer.r(MinecraftServer.java:560)
    ... 4 more

Same code as above except the infinite loop has been dealt with (same line numbers)

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

Forge_User_58953186 · Apr 7, 2013

MrBluebear3 Fixed, see recent commits/builds.

Hoolean · Apr 8, 2013

kumpelblase2 said: ↑

MrBluebear3 Fixed, see recent commits/builds.
Click to expand...

OK thanks! I managed to fix it myself in the meantime by only adding the desire once the RemoteEntity was tamed

Log in or Sign up

[LIB] [1.7] Remote entities - Next generation NPC library [No support]

TomShar

Forge_User_58953186

TomShar

Forge_User_58953186

TeeePeee

MylesIsCool

Forge_User_58953186

hebrecht

Forge_User_58953186

MylesIsCool

hebrecht

MylesIsCool

JeroenV

Forge_User_58953186

TeeePeee

hebrecht

Forge_User_58953186

MylesIsCool

CreeperShift

Forge_User_58953186

CreeperShift

Hoolean

MylesIsCool

Hoolean

Forge_User_58953186

Hoolean

Forge_User_58953186

Hoolean

Forge_User_58953186

Hoolean

Share This Page

[LIB] [1.7] Remote entities - Next generation NPC library [No support]

Share This Page

Useful Searches