I cant manage to make player only command and permissions work together

I can't seem to manage to make Haspermissions and sender instanceof Player work together, I have been trying a lot and can't seem to get a fix.

How do i make it that it will check the permissions and if the sender is a player and not a console.
I tryed a lot with

Code:java

 
    if (sender instanceof Player) {
 

But can't seem to get them working together, the command does work but the console giving this error when i try something:

Code:

2013-01-15 21:27:19 [WARNING] Unexpected exception while parsing console command "fly"
org.bukkit.command.CommandException: Unhandled exception executing command 'fly' in plugin EKCommands v0.2
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46)
at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:186)
at org.bukkit.craftbukkit.v1_4_6.CraftServer.dispatchCommand(CraftServer.java:514)
at org.bukkit.craftbukkit.v1_4_6.CraftServer.dispatchServerCommand(CraftServer.java:506)
at net.minecraft.server.v1_4_6.DedicatedServer.al(DedicatedServer.java:260)
at net.minecraft.server.v1_4_6.DedicatedServer.r(DedicatedServer.java:225)
at net.minecraft.server.v1_4_6.MinecraftServer.q(MinecraftServer.java:494)
at net.minecraft.server.v1_4_6.MinecraftServer.run(MinecraftServer.java:427)
at net.minecraft.server.v1_4_6.ThreadServerApplication.run(SourceFile:849)
Caused by: java.lang.ClassCastException: org.bukkit.craftbukkit.v1_4_6.command.ColouredConsoleSender cannot be cast to org.bukkit.entity.Player
at me.stickeric.ekcommands.EKCommands.onCommand(EKCommands.java:34)
at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44)
... 8 more

Where do i put the instance of player in this code correctly:
Without getting that error?

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
Player p = (Player) sender;
if(commandLabel.equalsIgnoreCase("fly")){
if(p.hasPermission("ek.fly")){
{
if (p.isFlying()) {
p.setFlying(false);
p.setAllowFlight(false);
p.sendMessage(ChatColor.DARK_RED + "You are not flying anymore.");
} else {
p.sendMessage(ChatColor.DARK_RED + "You are now Flying.");
p.setAllowFlight(true);
p.setFlying(true);
}
}
}
else
{
   p.sendMessage(ChatColor.BLUE + "No permissions :).");
}
       }
else if(commandLabel.equalsIgnoreCase("broadcast")){
     p.sendMessage(getConfig().getString("ekbroadcast"));
}
return false;
}
}
 

Thank you for your time.

 

Well, use the code you stated above "if (sender instanceof Player) {"

Use an else here, so if a player did not issue the command print the error to the console.

Then just simply check the permission within the instanceof Player?


I'm not entirely sure what your problem is, sorry.

 

If you ment like this, it's still giving an error, I think i'm doing something wrong with the else from if if(p.hasPermission("ek.fly")){ but im not 100% sure.

Code:java

 
public boolean onCommand(CommandSender sender, Command cmd, String commandLabel, String[] args){
Player p = (Player) sender;
if(commandLabel.equalsIgnoreCase("fly")){
if (sender instanceof Player) {
if(p.hasPermission("ek.fly")){
{
if (p.isFlying()) {
p.setFlying(false);
p.setAllowFlight(false);
p.sendMessage(ChatColor.DARK_RED + "You are not flying anymore.");
} else {
p.sendMessage(ChatColor.DARK_RED + "You are now Flying.");
p.setAllowFlight(true);
p.setFlying(true);
}
}
}else{
   p.sendMessage(ChatColor.BLUE + "Only the wonderfull staff members of EK has this command :).");
 
}
}
else{
System.out.println("Test");
 
}
 
       }
else if(commandLabel.equalsIgnoreCase("broadcast")){
     p.sendMessage(getConfig().getString("ekbroadcast"));
}
return false;
}
}
 

 

Try defining Player p after you have determined it is a player?

 

Thanks man!

For the people i have fixed it with this

Code:java

 
if (sender instanceof Player) {
Player p = (Player) sender;
if(p.hasPermission("ek.fly")){

 

np happy to help :3