Need help!! Can't get this to work!!

I have tried many different ways and I cannot get this to work. I have tried everything!
Here is my code:
package com.endlessshadow;

import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;

public class DeathListener implements Listener {
public EndlessHunger plugin;

public DeathListener(EndlessHunger plugin) {
this.plugin = plugin;
}

@EventHandler
public void onPlayerDeath(PlayerDeathEvent evt){
Player p = evt.getEntity();
String pname = p.getDisplayName();
plugin.Playing.remove(pname);
plugin.Dead.add(pname);
evt.setDeathMessage(ChatColor.RED + pname + ChatColor.AQUA + " Has died and was kicked from the games!");
p.kickPlayer("You have died and are out of the games!");
if(plugin.Playing.size()== 1){
plugin.getServer().broadcastMessage(ChatColor.AQUA + "The Games Have Ended!");
plugin.Playing.clear();
plugin.Dead.clear();
}
}
}

Please tell me what I am doing wrong! I can't get it right. The first part of it works(In Red) The second part doesn't(In Blue) PLEASE HELP!

Bump.

Also, there is no error in the console when a player dies.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Have you registered the event(s) in the main class with the plugin manager?

Also, please change your title to something more informative on the topic, if you are in this section making a thread we already assume that you are looking for help.

 

Can you do this with your code:
[syntax=java]PUT YOUR CODE HERE[/syntax]
Also, can we see your main class?

 

What is Playing ?

 

I would assume a list

 

We need to see the other class (EndlessHunger).
There is no syntax error, as seen here (formatted code from above)
Is there any error message from eclipse (or other IDE...)

Code:java

package com.endlessshadow;
 
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
 
public class DeathListener implements Listener {
	public EndlessHunger plugin;
 
	public DeathListener(EndlessHunger plugin) {
		this.plugin = plugin;
	}
 
	@EventHandler
	public void onPlayerDeath(PlayerDeathEvent evt) {
		Player p = evt.getEntity();
		String pname = p.getDisplayName();
		plugin.Playing.remove(pname);
		plugin.Dead.add(pname);
		evt.setDeathMessage(ChatColor.RED + pname + ChatColor.AQUA + " Has died and was kicked from the games!");
		p.kickPlayer("You have died and are out of the games!");
		if(plugin.Playing.size()== 1){
			plugin.getServer().broadcastMessage(ChatColor.AQUA + "The Games Have Ended!");
			plugin.Playing.clear();
			plugin.Dead.clear();
		}
	}
}

 

Have you tried instead of you own code this?:

Code:

@EventHandler
public void onPlayerDeath(PlayerDeathEvent evt){
Player p = evt.getPlayer();

Look at the last word.

 

Yeah I have them in my main class

Here is the DeathListener

Code:java

package com.endlessshadow;
 
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
 
public class DeathListener implements Listener {
public EndlessHunger plugin;
 
        public DeathListener(EndlessHunger plugin) {
                this.plugin = plugin;
        }
 
        @EventHandler
        public void onPlayerDeath(PlayerDeathEvent evt){
        Player p = evt.getEntity();
        String pname = p.getDisplayName();
        plugin.Playing.remove(pname);
        plugin.Dead.add(pname);
        evt.setDeathMessage(ChatColor.RED + pname + ChatColor.AQUA + " Has died and was kicked from the games!");
        p.kickPlayer("You have died and are out of the games!");
        if(plugin.Playing.size()== 1){
        plugin.getServer().broadcastMessage(ChatColor.AQUA + "The Games Have Ended!");
        plugin.Playing.clear();
        plugin.Dead.clear();
        }
        }
}

Here is the main class

Code:java

package com.endlessshadow;
 
import java.io.File;
import java.util.ArrayList;
import java.util.logging.Logger;
 
import org.bukkit.command.CommandExecutor;
import org.bukkit.configuration.file.FileConfiguration;
import org.bukkit.event.Listener;
import org.bukkit.plugin.java.JavaPlugin;
 
public class EndlessHunger extends JavaPlugin{
Logger log;
public Listener DeathListener = new DeathListener(this);
public Listener MoveListener = new DeathListener(this);
public ArrayList<String> Playing = new ArrayList<String>();
public ArrayList<String> Dead = new ArrayList<String>();
public FileConfiguration config;
public CommandExecutor CommandKit = new CommandKit(this);
public CommandExecutor CommandClear = new CommandClear(this);
 
public void onEnable(){
getServer().getPluginManager().registerEvents(DeathListener, this);
getServer().getPluginManager().registerEvents(MoveListener, this);
    getCommand("Kit").setExecutor(this.CommandKit);
    getCommand("Clearhg").setExecutor(this.CommandClear);
getLogger().info("EndlessHunger has been enabled!");
config = getConfig();
config.options().copyDefaults(true);
this.saveDefaultConfig();
boolean file = (new File("plugins/EndlessHunger/")).mkdir();
if(file){
getLogger().info("Successfully created plugin directory!");
}
}
public void onDisable(){
getLogger().info("EndlessHunger has been disabled!");
}
}

Nope, no error messages

The method getPlayer() is undefined for the type PlayerDeathEvent

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

I know this question might be stupid, but you add them to the list right?
Maybe you forogot a .getName() somewhere.

Other thought: replace "String pname = p.getDisplayName();"
With: String pname = p.getName();
Since the displayName might change!

 

Yeah I added them, i'll try to replace the getDisplayName with getName

Didn't work. Bump.

Also, just saying, everything else works except for the part where it broadcasts that the games have ended. That is the only part that does not work. Everything else works, the player get kicked, it's the right kick message, blah blah blah

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

It's 2am so Ima say something stupid, and hope it isn't... Use bukkit to broadcast instead of the plugin, everything seems right to me, so I got no clue

 

You are removing the player before checking if there is one left. do this

Code:java

if(plugin.Playing.isEmpty()){
plugin.getServer().broadcastMessage(ChatColor.AQUA + "The Games Have Ended!");
plugin.Playing.clear();
plugin.Dead.clear();
}

see if that works

 

Wouldn't there have to be a player left to win though? Then it would be if playing size==1 but if it is empty that means all the players have died, even the player that won.

 

Right didn't think of that. ok so you should do some debugging and tests. Add messages through out the code for what happens, also add a message saying everyone who is in the "Playing" section to see if they are actually being removed. also you can change the list to Player instead of String and then just add the player and remove the player from it.

EDIT: I also just noticed this
getServer().getPluginManager().registerEvents(DeathListener, this);
Try changing it to getServer().getPluginManager().registerEvents(new DeathListener(this));

 

Didn't work. I think the problem is in the if(plugin.Playing.size()== 1){ because it doesn't "register" that part and doesn't do what's inside of it

 

Print out the size of Playing to see what it is when there's one player left.

And: are you sure you add players to it? Because otherwise the size is always 0.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Yeah when they join the server they get added.... I think. I'll test it tomorrow.