How do I declare player in general?

I forgot how to declare the general player in bukkit. Meaning any random player that joins. What do I make Player p = ? This is prbably very simple but I had a brain fart and forgot =(

 

You would do:

PHP:

Player p = event.getPlayer();

That assumes that your event variable is called "event".

 

getPlayer gets underlined

Code:JAVA

   public boolean onCommand(CommandSender sender, Command command, String c, String[] args, Event event){
   Player send = (Player) sender;
   Player player = event.getPlayer();
   if(command.getName().equalsIgnoreCase("griefhere") && send.hasPermission("sc.slay")){
       if (sender instanceof Player){
       send.sendMessage(ChatColor.GREEN + "Mods have been notified of this grief.");
                       return true;
           }
       if(player.hasPermission("ma.get")){
       player.sendMessage(ChatColor.GREEN + send.getDisplayName() + " has found grief, teleport to them to fix it.");
       return true;
       }
       }
return false;
 
 
    }
}
 

 

Sorry, didn't know you were doing it in your onCommand. In that case, you should just be able to use your "send" variable you made. The "event.getPlayer()" won't work in an onCommand method.

Tell me if that works!

 

cant you do "sender" insteadof "player"
you can do sender.hasPermission
you can do sender.sendMessage

 

What you probably want to do is broadcast message to all players with specified permission. It is done by Bukkit.broadcast(message, permission)

Another thing is, you return true right after you find out that sender is player, which is before you notify mods.

 

How do I adress the permission? just as the normal ma.get or do "ma.get" or something? I can use chatColor, right?

 

message is String, which may contain colors. Permission is string like.this, which should not contain colors.

 

I did that, I think

Code:JAVA

   public boolean onCommand(CommandSender sender, Command command, String c, String[] args){
   Player send = (Player) sender;
   if(command.getName().equalsIgnoreCase("griefhere")){
       if (sender instanceof Player){
       send.sendMessage(ChatColor.GREEN + "Mods have been notified of this grief");
       if(send.hasPermission("ma.getticket")){
       send.sendMessage(ChatColor.GREEN + send.getDisplayName() + ChatColor.GOLD + " has found grief, telelport to them to fix it!");
       }
           return true;
           }
       }
return false;
 
 
    }

 

What you have done is that when someone types /griefhere, it tells him "Mods have been notified of this grief" and if he has "ma.getticket" permission, it also tells him "(His name) has found grief, telelport to them to fix it!"

replace

Code:

if(send.hasPermission("ma.getticket")){
send.sendMessage(ChatColor.GREEN + send.getDisplayName() + ChatColor.GOLD + " has found grief, telelport to them to fix it!");
}

with

Code:

Bukkit.broadcast(ChatColor.GREEN + send.getDisplayName() + ChatColor.GOLD + " has found grief, telelport to them to fix it!", "ma.getticket")

This way, everyone who has "ma.getticket" will recieve message with the name of the one who issued a command.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Still nothing my plugin.yml is fine.

 

I have been away for a little while, so I don't know exactly where you are in all of this, but have you registered your permissions and commands in your plugin.yml?

 

I don't understand.

 

Neither do I... I've been making commands the same for the past year and never had this problem. EVER.

Code:JAVA

name: ModAssistance
version: 1.0
main: me.football70500.modassistance.ma
commands:
  griefhere:
    description: Notifies online moderators of grief.
 

 

plugin.yml looks good, as long as your main class is "ma". I still don't get why my replacement solution doesn't work.

 

Maybe try putting your permissions in your plugin.yml. I got a NPE on my plugin if I didn't...

 

Could be true, but as always this will be depending on the stacktrace :3

 

Yea, I know, I just said that cause I haven't seen his stacktrace

 

Must just hate us XD

 

But really, is there anything wrong with it ? What is expected behavior and what is actual behavior ?