player.canSee code not working ?

Hey, I'm trying to create a command (/hide in my case) that turns the player invisible.

Code:

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
    Player player = (Player) sender;
    if(player.hasPermission("invisibleme.hide") == true){
        if(sender instanceof Player) {
            if(cmd.getName().equalsIgnoreCase("hide")){
                if(player.canSee(player) == false){
                    player.sendMessage(ChatColor.DARK_GREEN + "You are now invisible!");
                    for(Player ply : Bukkit.getOnlinePlayers()){
                        ply.hidePlayer(player);
                    }
                } else {
                    player.sendMessage(ChatColor.RED + "You are already invisible!");
                }
            }
        } else {
            sender.sendMessage(ChatColor.RED + "You must be a player!");
        }
    } else {
        player.sendMessage(ChatColor.RED + "You do not have permission.");
    }
   
    return false;
}

So what I want to do is check if the player is already invisible then if that is true then it will say "You are already invisible" and if false then it will make the player invisible. But, when I try it on my server, when it's set to false it always says "You are already invisible" (when I'm not) and if I set it to true it always says "You are invisible" when it's supposed to say "You are already invisible".

Anyone? Anyone ?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

So what you're saying is that it's doing the opposite of what it's supposed to do? If so, get rid of the " == false" in your "if" statement.

 

Also you're saying if(!player.canSee(player)),

meaning, if i cant see myself{ }

 

When I do that, It just ignores the else to that if.

Yeah, what should I put instead then ?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Store a player's visibility status as a boolean separately for tracking that stuff.

 

Code:java

 
for(Player other: Bukkit.getOnlinePlayers()){
    if(other.canSee(player)){
        other.hidePlayer(player);
        player.sendMessage("You are now invisible");
    }else{
        other.showPlayer(player);
        player.sendMessage("You have re-appeared");
    }
}

Although, like mbaxter said you might wanna store if a player is invisible or not somewhere else.

Like a file, or database or something of that nature.

that way you can say,

Code:java

if(getConfig().getBoolean(player.getName() + ".vanished")){
      // become invisible
}else{
    //become visible
}

that way, it persists after logging out.

 

Sabersamus When i use your code, and do the command "/hide" it makes me invisible and says "you are invisible blah blah" but, when i do it a second time is it supposed to make me visible? Cause it just says "you are invisible blah blah" and nothing happens. Here is my code for the command:

Code:java

public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
Player player = (Player) sender;
if(player.hasPermission("invisibleme.invisible") == true){
if(sender instanceof Player){
if(cmd.getName().equalsIgnoreCase("hide")){
for(Player other: Bukkit.getOnlinePlayers()){
if(other.canSee(player)){
other.hidePlayer(player);
player.sendMessage("invisible");
} else {
other.showPlayer(player);
player.sendMessage("visible");
}
}
}
} else {
sender.sendMessage("Must be player");
}
} else {
player.sendMessage("You do not have permission.");
}
return false;
}
 

 

Code:java

 
private boolean vanished = false;
 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
if(cmd.getName().equalsIgnoreCase("hide"){
if(sender instanceof Player){
Player player = (Player)sender;
if(player.hasPermission("blah")){
if(vanished == false){
for(Player other: Bukkit.getOnlinePlayers()){
if(!other.hasPermission("Make a permission so that admins or ops or something can still see everyone"){
other.hidePlayer(player);
}
}
vanished = true;
player.sendMessage(ChatColor.WHAT_EVER + "You are now vanished");
}else{
for(Player other: Bukkit.getOnlinePlayers()){
other.showPlayer(other);
}
player.sendMessage(ChatColor.WHAT_EVER + "You are no longer invisible");
vanished = false;
}
}
}
}
}

Another way you could do it, is make a hashmap

Code:java

public static HashMap<String, Boolean> vanished = Maps.newHashMap();

and where if(vanished == false){ replace that with, if(vanished.contains(player.getName()){


EDIT: Or a list, instead of a hashmap, that would work better

 

Sabersamus you just wrote something that would fall apart as soon as two people try using it at once

 

Thats why i edited it and said use a hashmap or a list