Setting weather doesn't work.

Discussion in 'Plugin Development' started by Dreeass, Apr 22, 2012.

Thread Status:
Not open for further replies.
  1. Offline

    Dreeass

    So in my class for setting the weather I do everything as usual and I'm getting a wrong result, what should happen is when the player types /weather he should get a message /weather<sun/storm>, which happens but when typing /weather sun it returns that it's no valid weathercondition. And by adding a 2 to each if statement to see what if statement it chooses I get a 2.

    Code:
    PHP:
    package me.Dreeass.VanillaPlus.Commands;
     
    import me.Dreeass.VanillaPlus.Main;
     
    import org.bukkit.ChatColor;
    import org.bukkit.World;
    import org.bukkit.command.Command;
    import org.bukkit.command.CommandExecutor;
    import org.bukkit.command.CommandSender;
    import org.bukkit.entity.Player;
     
    public class 
    Weather implements CommandExecutor {
     
        public static 
    Main plugin;
     
        public 
    Weather(Main instance) {
            
    plugin instance;
        }
     
        @
    Override
        
    public boolean onCommand(CommandSender senderCommand cmdString commandLabelString[] args) {
            final 
    Player playerSender = (Playersender;
            if (
    playerSender == null) {
                
    plugin.getServer().getLogger().info("This command can only be performed by a player in-game.");
            }
            else {
                if(
    playerSender.isOp() || playerSender.hasPermission("vanillaplus.weather")) {
                    if(
    args.length == 0) {
                        
    playerSender.sendMessage(ChatColor.RED "/weather <sun/storm>");
                    }
                    if(
    args.length == 1) {
                        
    World world playerSender.getWorld();
                        
    String weather args[0].toLowerCase();
                        if(
    weather == "sun") {
                            
    world.setStorm(false);
                            
    playerSender.sendMessage(
                                    
    ChatColor.GRAY "The weather in "+
                                    
    ChatColor.GOLD world.getName() +
                                    
    ChatColor.GRAY " has been set to " +
                                    
    ChatColor.GOLD "sunny" +
                                    
    ChatColor.GRAY "."
                                    
    );
                        }
                        if(
    weather == "storm") {
                            
    world.setStorm(true);
                            
    playerSender.sendMessage(
                                    
    ChatColor.GRAY "The weather in "+
                                    
    ChatColor.GOLD world.getName() +
                                    
    ChatColor.GRAY " has been set to " +
                                    
    ChatColor.GOLD "stormy" +
                                    
    ChatColor.GRAY "."
                                    
    );
                        }
                        else {
                            
    playerSender.sendMessage(ChatColor.GOLD args[0] + ChatColor.GRAY " is not a valid weathercondition.");
                        }
                    }
                    else {
                        
    World world plugin.getServer().getWorld(args[1]);
                        if(
    world != null) {
                            
    String weather args[0].toLowerCase();
                            if(
    weather == "sun") {
                                
    world.setStorm(false);
                                
    playerSender.sendMessage(
                                        
    ChatColor.GRAY "The weather in "+
                                        
    ChatColor.GOLD world.getName() +
                                        
    ChatColor.GRAY " has been set to " +
                                        
    ChatColor.GOLD "sunny" +
                                        
    ChatColor.GRAY "."
                                        
    );
                            }
                            if(
    weather == "storm") {
                                
    world.setStorm(true);
                                
    playerSender.sendMessage(
                                        
    ChatColor.GRAY "The weather in "+
                                        
    ChatColor.GOLD world.getName() +
                                        
    ChatColor.GRAY " has been set to " +
                                        
    ChatColor.GOLD "stormy" +
                                        
    ChatColor.GRAY "."
                                        
    );
                            }
                            else {
                                
    playerSender.sendMessage(ChatColor.GOLD args[0] + ChatColor.GRAY " is not a valid weathercondition.");
                            }
                        }
                        else {
                            
    playerSender.sendMessage(ChatColor.GOLD args[1] +
                                    
    ChatColor.GRAY " does not exist."
                                    
    );
                        }
                    }
                }
                else {
                    
    playerSender.sendMessage(ChatColor.GRAY "You do not have permission to use this command.");
                }
            }
            return 
    false;
        }
     
    }
    Btw how do I get my code on the forums to java because Code=java (and those brackets)doesn't work :p
     
  2. Offline

    ZNickq

    never use == on Strings, use string1.equals(otherString);

    Oh, and
    Code:java
    1.  
    2. String s = "Why doesn't it work?";
    3.  
     
    Dreeass likes this.
  3. Offline

    Dreeass

    Forgot that :/ *slap in tha face*
     
Thread Status:
Not open for further replies.

Share This Page