Getting an error with message broadcasting

Well here is a little piece of code that gives me an error :

Code:java

 
public class EListener extends EntityListener {
	Glass plugin;
 
	public EListener(Glass instance) {
		instance = plugin;
	}
 
	public void onEntityDeath(EntityDeathEvent event) {
		Entity e = event.getEntity();
		if (e instanceof Player) {
			Player p = (Player) e;
			plugin.getServer().broadcastMessage("[Server] " + p.getName() + plugin.dmsg);
		}
	}
}
 

plugin.dmsg is a configurable String (taken from the main class)
The problem is that i'm getting this error

2011-07-10 13:03:27 [SEVERE] Could not pass event ENTITY_DEATH to GlassBreak
java.lang.NullPointerException
at me.beatcomet.GP.EListener.onEntityDeath(EListener.java:19)
at org.bukkit.plugin.java.JavaPluginLoader$56.execute(JavaPluginLoader.java:635)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:58)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:321)
at net.minecraft.server.EntityPlayer.die(EntityPlayer.java:141)
at org.bukkit.craftbukkit.entity.CraftLivingEntity.setHealth(CraftLivingEntity.java:43)
at me.beatcomet.GP.BListener.onBlockBreak(BListener.java:39)
at org.bukkit.plugin.java.JavaPluginLoader$35.execute(JavaPluginLoader.java:483)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:58)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:321)
at net.minecraft.server.ItemInWorldManager.c(ItemInWorldManager.java:157)
at net.minecraft.server.ItemInWorldManager.a(ItemInWorldManager.java:121)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:460)
at net.minecraft.server.Packet14BlockDig.a(SourceFile:42)
at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:84)
at net.minecraft.server.NetworkListenThread.a(SourceFile:105)
at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:451)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:361)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)

 

Is dmsg a public member?

 

public member?

 

It's a member of the main class, but how is it initialized?
public String dmsg?
If it isn't, it won't be in scope and the listener can't use it.

 

Config file

 

You have to put

Code:

public

before the type declaration of the String.

 

2011-07-10 13:38:06 [SEVERE] Could not pass event BLOCK_BREAK to GlassBreak
java.lang.IllegalArgumentException: Health must be between 0 and 200
at org.bukkit.craftbukkit.entity.CraftLivingEntity.setHealth(CraftLivingEntity.java:39)
at me.beatcomet.GP.BListener.onBlockBreak(BListener.java:39)
at org.bukkit.plugin.java.JavaPluginLoader$35.execute(JavaPluginLoader.java:483)
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:58)
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:321)
at net.minecraft.server.ItemInWorldManager.c(ItemInWorldManager.java:157)
at net.minecraft.server.ItemInWorldManager.a(ItemInWorldManager.java:121)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:460)
at net.minecraft.server.Packet14BlockDig.a(SourceFile:42)
at net.minecraft.server.NetworkManager.b(NetworkManager.java:226)
at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:84)
at net.minecraft.server.NetworkListenThread.a(SourceFile:105)
at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:451)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:361)
at net.minecraft.server.ThreadServerApplication.run(SourceFile:422)

this is the new error i'm getting

 

Look at BListener.java line 39, it's a completely different file, your BlockListener, generating the error.
It appears as though you have passed an invalid number to setHealth(), which can only be 0-20.

 

The problem is that health can't be lower than 0 and I'm using setHealth in the BListener.
how can I fix it

Here is the code

Code:java

 
public class BListener extends BlockListener {
	Glass plugin;
 
	BListener(Glass instnace) {
		plugin = instnace;
	}
 
	public void onBlockBreak(BlockBreakEvent e) {
		Block b = e.getBlock();
		Player p = e.getPlayer();
		int mindamage = plugin.MinDamage;
		int maxdamage = plugin.MaxDamage;
		int chance = plugin.Chance;
		if (b.getType() == Material.GLASS) {
			Location loc = b.getLocation();
			ItemStack is = new ItemStack(Material.GLASS, 1);
			b.getWorld().dropItemNaturally(loc, is);
			int x = (int) (Math.random() * 100) + 1;
			Random rand = new Random();
			if (plugin.Baredamage == true) {
				if (p.getItemInHand().getTypeId() == 0) {
					if (x <= chance) {
						int y = rand.nextInt(maxdamage - mindamage + 1)
								+ (mindamage);
						int Health = p.getHealth();
						p.setHealth(Health - y);
						p.sendMessage("[Server] " + ChatColor.DARK_GREEN + plugin.Message);
					}
				}
			}
			if (plugin.Baredamage == false) {
				if (x <= chance) {
					int y = rand.nextInt(maxdamage - mindamage + 1)
							+ (mindamage);
					int Health = p.getHealth();
					p.setHealth(Health - y);
					p.sendMessage("[Server] " + ChatColor.DARK_GREEN + plugin.Message);
				}
			}
		}
	}
}
 

After changing it from p.setHealth to p.damage it does kill me but i'm getting the error I got in the first time (already added public before the string in the main class)

 

Do a check to see if player's health will be less than zero when y is subtracted, and in that event just set it to zero.

 

Did at and now it says that there is an error in this line

plugin.getServer().broadcastMessage("[Server] " + p.getName() + plugin.dmsg);

 

@beatcomet
Change line 3 to public Glass plugin;
Then, 5 and 6 typo, must be instance.

 

What error?

 

Why would he make it public?

 

@darklust
Why not?
Rule out everything possible.
Also, you're incorrect about making the string public.
http://download.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html'

However I'm pretty sure his constructor has to be public.

 

The plugin instance does not have to be public as it is passed by the constructor to an instance that need only be accessible within the class.
I understand access control, but it doesn't appear he has a package declaration at the beginning of the file.

 

There is a package declaration in the beggining of the file, I just removed it from the code I copied to this thread because I thought it's not necessary.

As you can see I also removed the imports...

 

Glancing through, I don't think anyone actually pointed out the problem.

plugin is your null value. You set instance = plugin, rather than plugin = instance.

Change line 6 of EListener.