Solved Cancel menu action when clicking on bottom inventory

Hello,

I made a custom inventory which works fine. However, when I click on the bottom inventory (Brick), it does the same as when I click on the added items in the top inventory (Book). How can I cancel this event?



This is the code I used to add items to my inventory and perform actions:

Code:

 @EventHandler
    public void onInventoryClick(InventoryClickEvent e) {
        Player p = (Player) e.getWhoClicked();

        Menu().getName())) return

        if(e.getInventory().getTitle().contains("Vote")) {
            e.setCancelled(true);

            if (e.getRawSlot() < e.getInventory().getSize() || e.isShiftClick()) {
                e.setCancelled(true);
            }

            if (e.getCurrentItem() == null) {
                return;
            }

            int sizeOfLinks = instance.getConfig().getConfigurationSection("Vote.Votelinks").getKeys(false).size();
            System.out.println(sizeOfLinks);

            for (String s : instance.getConfig().getConfigurationSection("Vote.Votelinks").getKeys(false)) {
                String serviceName = instance.getConfig().getString("Vote.Votelinks." + s + ".servicename");
                String serviceUrl = instance.getConfig().getString("Vote.Votelinks." + s + ".url");

                Integer serviceId = new Integer(s);

                if(e.getSlot() == (serviceId - 1)) { // Minus 1. Because slots starts at 0.
                    e.setCancelled(true);
                    p.sendMessage(Messages.Prefixes.VOTE + ChatColor.GREEN + serviceName + ": " + ChatColor.GRAY + serviceUrl);
                    p.closeInventory();
                }
            }
        }
    }

 

@AppleMen

Code:java

 
@EventHandler
public void onInvClick(InventoryClickEvent event) {
         if(event.getInventory().getTitle().equals("container.crafting")
                           && event.getRawSlot() > 9) {
          event.setCancelled(true);
    }
}
 

We check if the player is clicking in their own inventory, then if the raw slot is greater than 9, we do this because when you open a workbench that inventory is also the "container.crafting" inventory, and that has slots 1-9.

 

Unfortunately the action after the slot check (Line #27 in my first post) still executes when clicking on the brick from the image.

 

@AppleMen Add the code inside the event i showed you to the listener you made at the top, so before you do any of your checking, add the check i made, like so:

Code:java

 
@EventHandler
    public void onInventoryClick(InventoryClickEvent e) {
        Player p = (Player) e.getWhoClicked();
 
        if(event.getInventory().getTitle().equals("container.crafting")
                     && event.getRawSlot() > 9) {
               e.setCancelled(true);
         }
 
        Menu().getName())) return
 
        if(e.getInventory().getTitle().contains("Vote")) {
            e.setCancelled(true);
 
            if (e.getRawSlot() < e.getInventory().getSize() || e.isShiftClick()) {
                e.setCancelled(true);
            }
 
            if (e.getCurrentItem() == null) {
                return;
            }
            int sizeOfLinks = instance.getConfig().getConfigurationSection("Vote.Votelinks").getKeys(false).size();
            System.out.println(sizeOfLinks);
 
            for (String s : instance.getConfig().getConfigurationSection("Vote.Votelinks").getKeys(false)) {
                String serviceName = instance.getConfig().getString("Vote.Votelinks." + s + ".servicename");
                String serviceUrl = instance.getConfig().getString("Vote.Votelinks." + s + ".url");
 
                Integer serviceId = new Integer(s);
 
                if(e.getSlot() == (serviceId - 1)) { // Minus 1. Because slots starts at 0.
                    e.setCancelled(true);
                    p.sendMessage(Messages.Prefixes.VOTE + ChatColor.GREEN + serviceName + ": " + ChatColor.GRAY + serviceUrl);
                    p.closeInventory();
                }
            }
        }
    }
 

EDIT: Actually in your case, you should be doing this:

Code:java

 
if(event.getRawSlot() > 8) {
               e.setCancelled(true);
         }
 

So:

Code:java

 
 
@EventHandler
    public void onInventoryClick(InventoryClickEvent e) {
        Player p = (Player) e.getWhoClicked();
 
        if(e.getRawSlot() > 8) {
               e.setCancelled(true);
         }
 
        Menu().getName())) return
 
        if(e.getInventory().getTitle().contains("Vote")) {
            e.setCancelled(true);
 
            if (e.getRawSlot() < e.getInventory().getSize() || e.isShiftClick()) {
                e.setCancelled(true);
            }
 
            if (e.getCurrentItem() == null) {
                return;
            }
            int sizeOfLinks = instance.getConfig().getConfigurationSection("Vote.Votelinks").getKeys(false).size();
            System.out.println(sizeOfLinks);
 
            for (String s : instance.getConfig().getConfigurationSection("Vote.Votelinks").getKeys(false)) {
                String serviceName = instance.getConfig().getString("Vote.Votelinks." + s + ".servicename");
                String serviceUrl = instance.getConfig().getString("Vote.Votelinks." + s + ".url");
 
                Integer serviceId = new Integer(s);
 
                if(e.getSlot() == (serviceId - 1)) { // Minus 1. Because slots starts at 0.
                    e.setCancelled(true);
                    p.sendMessage(Messages.Prefixes.VOTE + ChatColor.GREEN + serviceName + ": " + ChatColor.GRAY + serviceUrl);
                    p.closeInventory();
                }
            }
        }
    }
 

 

Still doesn't affect :/ It even happens when I click on the 1st or 2nd empty slot next to the brick.

 

Anyone knows how to solve this??

 

@AppleMen

Use the InventoryView to test where the event is happening, also, your logic doesn't make any sense. Here's how I would do it. This cancels any event that would modify the upper inventory, leaving the lower inventory free to be adjusted by the player. If the click happens in the upper inventory, it checks if the clicked item is a book and then and only then does it execute your vote code.

Code:

@EventHandler
    public void onInventoryClick(InventoryClickEvent e)
    {
         Player p = (Player) e.getWhoClicked();
         InventoryView view = e.getView();
         int slotNum = e.getRawSlot();
 
        if(e.getInventory().getTitle().contains("Vote"))
        {
            if (e.isShiftClick())
                e.setCancelled(true);

            if (slotNum < view.getBottomInventory().getSize())
            {
                e.setCancelled(true);

                if (e.getCurrentItem().getType.equals(Material.BOOK))
                {
                    int sizeOfLinks = instance.getConfig().getConfigurationSection("Vote.Votelinks").getKeys(false).size();
        
                    for (String s : instance.getConfig().getConfigurationSection("Vote.Votelinks").getKeys(false))
                    {
                        String serviceName = instance.getConfig().getString("Vote.Votelinks." + s + ".servicename");
                        String serviceUrl = instance.getConfig().getString("Vote.Votelinks." + s + ".url");
        
                        Integer serviceId = new Integer(s);
        
                        if(e.getSlot() == (serviceId - 1))
                        {
                            e.setCancelled(true);
                            p.sendMessage(Messages.Prefixes.VOTE + ChatColor.GREEN + serviceName + ": " + ChatColor.GRAY + serviceUrl);
                            p.closeInventory();
                        }
                    }
                }
            }
        }
    }

 

That did the job! Thank you very much