[TP/CHAT/ECON] ShopAds v1.73 - Let shop-owners advertise to players [1337]

Discussion in 'Inactive/Unsupported Plugins' started by Hpiz, May 11, 2011.

  1. Offline

    Hpiz

    ShopAds - The Ad Agency Plugin

    NEW HOMEPAGE OF THIS PLUGIN - ALL FUTURE RELEASES WILL BE HERE

    Version: 1.72

    Purpose:
    To allow players to advertise to other players.

    Description:

    A full featured Advertising/Teleportation Plugin.

    Users are allowed to create advertisement messages to broadcast allowing other players to teleport to the stores of the advertisement.

    Features:
    • MULTI-WORLD
    • MULTI-ADS
    • Users with permission may send a message to the public
    • TP players to shops advertising with /shop.
    • Re-settable shop locations
    • Announcement radius
    • Flat-File ads system (Simple for you, and me)
    • When message is created, ShopAds records the position and can tp players there
    • All users may turn on or off, whether they receive the ads (Depending on 'sendToAll')
    • Refund for early termination (Soon to be Configurable [percentage returned])
    • Charges per hour of advertising (Configurable)
    • Multiple Shops per player (Configurable)
    • Max Ad run time (Configurable)
    • Sends ads on a fixed interval (Configurable)
    • Random or sequential order (Configurable)
    • Charge for tp and Inter-World tp (Configurable)
    • Choose whether to consume the money gathered or give to shop owner
    • And More
    Requires - Register, and economy plugin, and a permissions plugin

    Plugin Written By: Hpiz
    Special Thanks to Joy for the initial debugging
     
  2. Offline

    gamingvortex

    I can see this causing Majour spam, does this charge the players for adverts?

    Maybe make it so admins can enable it they can only post it one time.
     
  3. Offline

    Killie01

    you can deny ads anyway, and making a shop costs money (if set to that)
    but ad prices would be awesome
     
  4. Offline

    Hpiz

    It will be a pay per hour to have a one line ad and other players the ability to tp to the store at the position the creator made the ad.

    And as killie pointed out each player has the ability to control whether they are receiving ads or not.
     
  5. Offline

    Hpiz

    This plugin could use some bug testing, if you're interested please download and test my plugin. Though bugs should be minimal.
     
  6. Offline

    Plague

    the title has to show latest recommended CB not development one
     
  7. Offline

    Hpiz

    Thanks wasn't exactly sure on that one Plague
     
  8. Offline

    Hpiz

    Just Updated to 1.25, really stable now and running good let me know how it runs for everyone
     
  9. Please rename /shop command, or provide an alias, that command is used by at least one major Shop plugin, that actually provides a....shop :p

    ===
    Edit:

    12:09:15 [SEVERE] java.lang.ArithmeticException: / by zero
    12:09:15 [SEVERE] at org.hpiz.ShopAds.timerThread.run(timerThread.java:57)
    12:09:15 [SEVERE] at org.bukkit.craftbukkit.scheduler.CraftWorker.run(CraftWorker.java:34)
    12:09:15 [SEVERE] at java.lang.Thread.run(Thread.java:662)

    ====
    maxShops=1
    announceInterval=600
    cost=200
    maxAdRunTime=24
    random=true
    sendToAll=false
    =====

    And had created 1 simple test ad...
     
  10. Offline

    Hpiz

    I
    Included in 1.26 update, thanks.
     
  11. Offline

    TheNander

    I sense this may not work with LocalShops. Is there a way to change the /shop command to something else?
     
  12. Offline

    Hpiz

    you can use /shops
     
  13. Having a few issues and thoughts:

    - Can you please make a config flag, to make it so, Shop Teleports only work while an Ad is active? I want the payment for the ad, to also grant the teleport, not just have a permanent free teleport.

    - It seems this plugin does not obey the unload/load plugin commands? I removed the JAR at some point, did a /reload, but it still worked.

    - Can you please make a config flag that disables the /shop command? This still interferes with out actual /shop plugin. The /shops command works great.

    Thanks!
     
  14. Offline

    Hpiz

    Thanks for the bug info, I've known of a few of these. I am renovating the shop system that should fix the teleport and expiration issues. I will have to look into the second issue. And for the third, yea np on that one. I appreciate the feedback.
     
  15. Eh, the thread is named 1.3, but the download is 1.26. I tested it anyways, and the /shop command is still breaking due to this. With the option set to true, so I presume it's 1.26 actually ?
     
  16. Offline

    Hpiz

    you were right, never updated the link. Long night. Finished update at 3 am.

    Download link updated
     
  17. Loaded 1.3 now.

    usingShops=true

    My /shop command is entirely broken now, does nothing. The usingShops=true is thus not doing what it should do, namely totally leave /shop untouched.
     
  18. Offline

    Hpiz

    idk what to say, on my test server with localshops and shopads on it /shop triggers localshops and /shops works for shopads, double-check your plugins directory to make sure that no other shopads.jar files exist as older versions had a diferent name. If problem continues please paste the console error code.
     
  19. Offline

    xlilcasper

    Confirmed, with usingShops=true the /shop command does nothing with LocalShops. This may have to do with the order plugins load?
     
  20. Offline

    Hpiz

    Uploaded a version that hopefully does not respond or interfere to /shop in any way
     
  21. Fixed /shops, thanks :)

    But, now I get an error when typing /ad or /ads. "/ad ?" does work however.

    Code:
    09:07:53 [SEVERE] null
    org.bukkit.command.CommandException: Unhandled exception executing command 'ad' in plugin ShopAds v1.31
            at org.bukkit.command.PluginCommand.execute(PluginCommand.java:37)
            at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:97)
            at org.bukkit.craftbukkit.CraftServer.dispatchCommand(CraftServer.java:278)
            at net.minecraft.server.NetServerHandler.handleCommand(NetServerHandler.java:701)
            at net.minecraft.server.NetServerHandler.chat(NetServerHandler.java:666)
            at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:660)
            at net.minecraft.server.Packet3Chat.a(Packet3Chat.java:32)
            at net.minecraft.server.NetworkManager.a(NetworkManager.java:196)
            at net.minecraft.server.NetServerHandler.a(NetServerHandler.java:75)
            at net.minecraft.server.NetworkListenThread.a(SourceFile:100)
            at net.minecraft.server.MinecraftServer.h(MinecraftServer.java:377)
            at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:292)
            at net.minecraft.server.ThreadServerApplication.run(SourceFile:394)
    Caused by: java.lang.ArrayIndexOutOfBoundsException: 0
            at org.hpiz.ShopAds.ShopAds.onCommand(ShopAds.java:335)
            at org.bukkit.command.PluginCommand.execute(PluginCommand.java:35)
            ... 12 more
    ====

    Also, possibly a minor thing, not sure how it works. But with sendToAll=true, I can still use /ad on and /ad off, and it tells me enabled/disabled. To prevent confusion, should likely change that somehow, different options to do that I guess.

    ====

    If possible, some lines to clean up. Ideally, there should be a space after [ShopAds] on every line that uses it.

    And /shops with 0 shops says: "The are no", should be "There are no".

    Ty :)

    ====

    Ok, well I can't get 1.31 to do anything really...

    Config
    ====
    maxShops=1
    announceInterval=60
    cost=200
    maxAdRunTime=24
    random=true
    sendToAll=true
    usingShops=true
    ====

    I made an ad, yet I see no advertising, should be once every minute. I tried /ad on, even though that should not be needed. Also, /shops says there's none.

    Data file looks fine:
    ===
    <shop>
    Name=Joy
    Ends=1306138159797
    Location=2286.235860208825/70.0/2201.4932764188466,18.969942,180.5744
    Message=Can you read me?
    Advertising=true
    Expired=false
    </shop>
     
  22. Offline

    Hpiz

    1.35 released with fixes on all of Joy's issues and anyone with localshops
     
  23. Awesome!

    Feature request: send the owner of a Shop a notification when someone uses their /shops teleport!
     
    yoyosamo likes this.
  24. Offline

    Hpiz

    Sounds like a good idea will be in update after 1.6 is released, btw any chance you could whitelist me for your amazing server, always wanted to join. IGN is Hpiz
     
  25. Of course, done!

    Request:

    Config flag to enable this: When creating an ad, immediately display/run it once after creation.

    ===

    Issue: the shop warp needs to store the World as well, otherwise, when using the /shops teleport while being in another World, you end up on the coordinates in that world!

    EDIT by Moderator: merged posts, please use the edit button instead of double posting.
     
    Last edited by a moderator: Jul 16, 2016
  26. Offline

    Hpiz

    I will include a config flag in the next update, and for the world issue. The plugin is not yet multi-world compatible, currently it will tp you to first world, called "world", I will try to integrate multi-world support in the next release as well, if not it will be in the one after that.
     
  27. That behaviour would be fine, but is not what I am seeing, people using /shops from a different world than "world" remain in that world, if they would be ported to the main world, that would work for me :p
     
  28. Offline

    Hpiz

    Interesting, nonetheless will soon not be an issue.
     
  29. Any news? Would love this awesome feature back :)
     
  30. Offline

    Hpiz

    Next release is on its way here's what to expect...

    New permission node for admins 'sa.admin'
    Re-settable shop locations
    MultiWorld Support
    Multiple Ads per Player
    New reload command (admins)
    New disable command (admins)
    New command '/ad list' which lists all ads currently running to the player

    Release in 1-2 days, thanks for the support.
     

Share This Page