My plugin is acting different on my servers

My plugin acts differently on both of my servers
one my own personal and the other my official server on server one it works fine and does what it is supposed to do on the other one it loops and just stops. I know it has something to do with the amount of players and how I get them but I do not know how to stop it.

what gets called and is supposed to do stuff

Code:java

public void onSignchange(SignChangeEvent event){
        int lineCount = 1;
        String linetwo = event.getLine(1);
        Player placer = event.getPlayer();
        console.sendMessage(placer.getName()+" has created a sign");
        for(OfflinePlayer offlineplayer:Bukkit.getOfflinePlayers()){
            Player player =offlineplayer.getPlayer();;
            if(event.getLine(0).equalsIgnoreCase("[RankSign]"))
                if(placer.hasPermission("ranksign.create")){
                    if(Main.permission.playerInGroup(player, linetwo)){
                        if (lineCount > 3)
                            break; // Break out of the loop so you don't get an exception if you try setting line 5 (line 4, in terms of arrays), since that line won't exist on the sign.
 
                        event.setLine(lineCount, player.getName());
                        String prefix = Main.chat.getPlayerPrefix(player);
                        lineCount++;
                      //It never gets here 
 
event.setLine(0,ChatColor.translateAlternateColorCodes('&',prefix));
                        placer.sendMessage(ChatColor.GREEN+ "RankSign Created successfully for group"+event.getLine(0));
                    }
                    else{
                       placer.sendMessage(ChatColor.RED+"No player in Group: "+ChatColor.BLACK+"["+ChatColor.RESET+event.getLine(1)+ChatColor.RED+ChatColor.BLACK+ "]"+ChatColor.RED+ " could be found!!");
                        console.sendMessage("Sign has failed");
                    }
                }
                else{
                //Does Send this a million times but I know why    
 
                 placer.sendMessage(ChatColor.RED+"You Do NOT have the right permissions!!!");
                    console.sendMessage("Sign has failed");
                }
        }
    }

If the sign is
[ranksign]
owner

on server one it will set the sign to
[owner]
(player)
(player)
(player)

On server two it will sit there and set the sign to
[ranksign]
owner


Any ideas?

 

Get any errors in the console?

 

@Rocoty
Nope no errors

 

@Pacothegint
So it works on one server, but not the other? If it is the same exact version of the plugin, it might be incompatible with another plugin on that server.

 

@Pacothegint Are you using the same server software? Is it an official craftbukkit build?

 

@Skionz
Both servers are a 1.8 spigot build that I compiled

@Tehmaker
It's not my plugins just checked them.
Also not sure why this was moved as this is a development problem?

@Skionz @Tehmaker

Hold it I just found this error message

caused by: java.lang.NullPointerException
at net.milkbowl.vault.permission.Permission.playerInGroup(Permission.java:560) ~[?:?]
at percycraft.fluctis.com.PlayerListener.onSignchange(PlayerListener.java:32) ~[?:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_03]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) ~[?:1.7.0_03]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1


that means

Code:java

if(Main.permission.playerInGroup(player, linetwo)){
//Do stuff
}
 

is causing the error but that makes no since because it does not on my personal server

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

@Pacothegint Post both of the relevant classes in their entirety.

 

@Skionz

Code:java

 
package percycraft.fluctis.com;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.OfflinePlayer;
import org.bukkit.command.ConsoleCommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.block.SignChangeEvent;
 
public class PlayerListener
implements Listener
{
    public PlayerListener(Main plugin)
 
    {
    }
    ConsoleCommandSender console = Bukkit.getServer().getConsoleSender();
 
    @EventHandler(priority=EventPriority.NORMAL, ignoreCancelled=true)
    public void onSignchange(SignChangeEvent event){
        int lineCount = 1;
        String linetwo = event.getLine(1);
        Player placer = event.getPlayer();
        console.sendMessage(placer.getName()+" has created a sign");
        for(OfflinePlayer offlineplayer:Bukkit.getOfflinePlayers()){
            Player player =offlineplayer.getPlayer();;
            if(event.getLine(0).equalsIgnoreCase("[RankSign]"))
                if(placer.hasPermission("ranksign.create")){
                    if(Main.permission.playerInGroup(player, linetwo)){
                        if (lineCount > 3)
                            break; // Break out of the loop so you don't get an exception if you try setting line 5 (line 4, in terms of arrays), since that line won't exist on the sign.
 
                        event.setLine(lineCount, player.getName());
                        String prefix = Main.chat.getPlayerPrefix(player);
                        lineCount++;
                        event.setLine(0,ChatColor.translateAlternateColorCodes('&',prefix));
                        placer.sendMessage(ChatColor.GREEN+ "RankSign Created successfully for group"+event.getLine(0));
                    }
                    else{
                        placer.sendMessage(ChatColor.RED+"No player in Group: "+ChatColor.BLACK+"["+ChatColor.RESET+event.getLine(1)+ChatColor.RED+ChatColor.BLACK+ "]"+ChatColor.RED+ " could be found!!");
                        console.sendMessage("Sign has failed");
                    }
                }
                else{
                    placer.sendMessage(ChatColor.RED+"You Do NOT have the right permissions!!!");
                    console.sendMessage("Sign has failed");
                }
        }
    }
}
 

this is the only class that has the error

But here is the main

Code:java

 
package percycraft.fluctis.com;
 
import net.milkbowl.vault.chat.Chat;
import net.milkbowl.vault.permission.Permission;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.command.ConsoleCommandSender;
import org.bukkit.plugin.RegisteredServiceProvider;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin
{   
    public static Permission permission = null;
    public static Chat chat = null;
    ConsoleCommandSender console = Bukkit.getServer().getConsoleSender();
    public void onEnable()
    {
        setupPermissions();
        setupChat();
        Bukkit.getPluginManager().registerEvents(new PlayerListener(this), this);
        console.sendMessage(ChatColor.AQUA+"["+getName()+"]" + " version" + getDescription().getVersion() + " by paocthegint"+ChatColor.GREEN+ " enabled!");
    }
 
    public void onDisable()
    {
 
        console.sendMessage(ChatColor.GREEN+"["+getName()+"]" +ChatColor.RED + " Disabled.");
    }
      private boolean setupPermissions()
      {
        RegisteredServiceProvider<Permission> permissionProvider = getServer().getServicesManager().getRegistration(Permission.class);
        if (permissionProvider != null) {
          permission = (Permission)permissionProvider.getProvider();
        }
        return permission != null;
      }
 
      private boolean setupChat()
      {
        RegisteredServiceProvider<Chat> rsp = getServer().getServicesManager().getRegistration(Chat.class);
        chat = (Chat)rsp.getProvider();
        return chat != null;
      }
}
 

 

at net.milkbowl.vault.permission.Permission.playerInGroup(Permission.java:560) ~[?:?]

means that the NPE is thrown from Vault code, so i suggest digging up the arguments.

if(Main.permission.playerInGroup(player, linetwo)

suggests that player or linetwo would be null - in a SignChangeEvent the player should not be null (some events can return null on some retrievel methods, but not for players causing the event). I used to check lines for null which i get from events/signs always - strong suggestion: check lines for null before using them. If you use getLines, check that for null too.

Another thing is to log a warning in onEnable, if permissions (or chat) can't be set up, but that doesn't seem to be the problem here.

Edit: And check if your version of Vault is not buggy, if you don't have null lines.

 

@asofold
Its not vault as i used the jar from my official server on my personal one and it works fine

@Skionz
any ideas?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

@Pacothegint Your spacing could be incorrect above the package, so it is either line 1 that is null, or 2.

 

@Skionz
nope works just fine on my personal server with all plugins from my production one

 

Check the arguments you are passing to Vault for null, specifically if you get lines from signs.