Development Assistance Sending a HashMap's contents to a player

Hello. So i'm making a plugin called StatsPro, and in this plugin it stores the player's kills and deaths in a HashMap. The only problem I have in it is when I attempt to retrieve the player's info from the HashMap and send it in a form of a message, Bukkit completely ignores that message. If I attempt to create a integer and make it equal to getting the player's contents in one of the HashMap's, it gives me an internal error. Thanks in advance

Main Class:

Code:java

package com.guildlaunch.platinumverse.statspro;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
 
    private Kills killsclass;
    private Deaths deathsclass;
 
    public void onEnable() {
        getServer().getPluginManager().registerEvents(new Kills(), this);
        getServer().getPluginManager().registerEvents(new FirstJoin(), this);
        getServer().getPluginManager().registerEvents(new Deaths(), this);
        getConfig();
    }
 
    public void onDisable() {
        getConfig().options().copyDefaults(true);
        saveDefaultConfig();
        saveConfig();
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
        Player player = (Player) sender;
 
        if(cmd.getName().equalsIgnoreCase("stats")) {
            player.sendMessage(ChatColor.RED + "[Stats]");
            player.sendMessage(ChatColor.GREEN + "Kills: " + ChatColor.AQUA + killsclass.killamount);
            player.sendMessage(ChatColor.GREEN + "Deaths: " + ChatColor.AQUA + deathsclass.deathamount);
            player.sendMessage(ChatColor.GREEN + "KDR: " + (killsclass.killamount / deathsclass.deathamount));
            return true;
        }
 
        return false;
    }
 
}

First Join Class:

Code:java

package com.guildlaunch.platinumverse.statspro;
 
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.event.player.PlayerJoinEvent;
 
public class FirstJoin implements Listener {
 
    private Main plugin;
    private Kills killsclass;
    private Deaths deathsclass;
 
    public void onPlayerJoin(PlayerJoinEvent event) {
        Player player = event.getPlayer();
 
        if(!(player.hasPlayedBefore())) {
            killsclass.kills.put(player, killsclass.killamount);
            deathsclass.deaths.put(player, deathsclass.deathamount);
            plugin.getConfig().set("stats." + player.getName() + ".kills.", killsclass.kills.get(player));
            plugin.getConfig().set("stats." + player.getName() + ".deaths.", deathsclass.deaths.get(player));
        }
    }
 
}

Kills Class:

Code:java

package com.guildlaunch.platinumverse.statspro;
 
import java.util.HashMap;
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
 
public class Kills implements Listener {
 
    HashMap<Player, Integer> kills = new HashMap<Player, Integer>();
 
    public int killamount = 0;
 
    @EventHandler
    public void onPlayerKill(PlayerDeathEvent event) {
 
        Player player = (Player) event.getEntity().getKiller();
 
        if(event.getEntity().getKiller() != null) {
 
            killamount++;
            kills.remove(player);
            kills.put(player, killamount);
 
        }
 
 
    }
    }

Deaths Class:

Code:java

package com.guildlaunch.platinumverse.statspro;
 
import java.util.HashMap;
 
import org.bukkit.entity.Player;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
 
public class Deaths implements Listener {
 
    HashMap<Player, Integer> deaths = new HashMap<Player, Integer>();
 
    public int deathamount = 0;
 
    public void onPlayerDeath(PlayerDeathEvent event) {
 
        Player player = (Player) event.getEntity();
 
        deathamount++;
 
        deaths.remove(player);
        deaths.put(player, deathamount);
 
    }
 
}

Oh by the way, in the Main class, I was experimenting so I tried putting the kill amount and the death amount in there, it also gave me the internal error.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Bump?

 

Code:

private Kills killsclass;
    private Deaths deathsclass;
 
    public void onEnable() {
        getServer().getPluginManager().registerEvents(new Kills(), this);
        getServer().getPluginManager().registerEvents(new FirstJoin(), this);
        getServer().getPluginManager().registerEvents(new Deaths(), this);
        getConfig();
    }

The problem I see here is you're making a variable but you're not assigning it. I think one way you can fix this is before u register all the events, do "killsclass = new Kills();" and same for the others.

 

Ok i'll try that and report back

 

Cloaking_Ocean so now it displays the kills and deaths messages with /stats, but it says I have null kills and deaths.

 

haydenaa Gahh the casting

 

Skionz Lol, I know your a pro at Bukkit so could you help me a little?

 

@ahydenaa I believe that Skionz was talking about how you are casting your Player object from event.getEntity() when you could just as easily make a Player object without casting with event.getPlayer(); Unless I'm super out of it and you can't do that with PlayerDeath (Event thought it specifies player). All I can say for now, Good luck I might be back later to cretique u some more

 

Have a hashmap for every stat you want to save.

Then have one, I repeat, one listener that increases all these values on event. When sending stats, just use for example sendMessage ("Deaths: " + deathStat.get (p));

 

haydenaa If your making a plugin to save stats then I would suggest using a database or a file to save data as a hash map will be lost when the program stops.

 

Skionz I was planning to use a config.yml file, but i'm kind of new to bukkit (not that new) and I don't properly know how to setup and save the files. Do I do something like getConfig().set("stats." + player.getName() + ".kills", kills.get(player)); or something like that. Sorry, like I said i'm kinda new so to get it would I do getConfig().get("stats." + player.getName() + ".kills") or replace the get with getString?

Cloaking_Ocean I just checked and there is no event.getPlayer(); for PlayerDeathEvents so I was originally right

Skionz also, should I copy the defaults for the config? I'm not sure what that does.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

It creates default values when the config is created.

 

Skionz got it

Skionz AronTheGamer Cloaking_Ocean It's still telling me in-game that I have null kills and deaths. Can someone attempt to help me?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Post the stack-trace and the class pertaining to it.

 

Skionz Summing it up: It's telling me there's a NullPointerException at line 32 of my Main.java, which happens to be the line where I tell the player how many kills they have. Is there an error in my Kills.java class or something?

 

haydenaa Their kills are probably null.

 

Skionz It would say the same for deaths, but that means there's an error in my FirstJoin class because it's supposed to put them at 0 deaths and kills if it's their first time joining. Sorry if i'm bugging you, but can you help me with this?

 

When getting a value check if it is null first.

 

Skionz so just if(kills.get(player) != null) ?

 

haydenaa It would be very useful if you could post code from the class you are having trouble with and any other classes that are linked from that code. There could be many issues that we could think of with the obscurity you have shown us.

 

Unrelated to the actual issue, but please use UUID's for storing their data. Just imagine what would happen if someone were to change their name!

Also, for Stats, you *could* use my API

 

Lolmewn it's not currently possible to change a name, right?

Cloaking_Ocean , i've narrowed it down to 2 classes:

Code:java

package com.guildlaunch.platinumverse.statspro;
 
import org.bukkit.ChatColor;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.entity.Player;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
 
    private static Listeners listeners;
    public static Main plugin;
 
    public void onEnable() {
        plugin = this;
        getServer().getPluginManager().registerEvents(new Listeners(), this);
        getConfig();
    }
 
    public void onDisable() {
        getConfig().options().copyDefaults(true);
        saveConfig();
        plugin = null;
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args) {
 
        Player player = (Player) sender;
 
        if(cmd.getName().equalsIgnoreCase("stats")) {
            player.sendMessage(ChatColor.RED + "[Stats]");
            player.sendMessage(ChatColor.GREEN + "Kills: " + ChatColor.AQUA + listeners.kills.get(player));
            player.sendMessage(ChatColor.GREEN + "Deaths: " + ChatColor.AQUA + listeners.deaths.get(player));
            player.sendMessage(ChatColor.GREEN + "KDR: " + (listeners.killamount / listeners.deathamount));
            return true;
        }
 
        return false;
    }
 
}

And

Code:java

package com.guildlaunch.platinumverse.statspro;
 
import java.util.HashMap;
 
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.player.PlayerJoinEvent;
 
public class Listeners implements Listener {
 
    HashMap<Player, Integer> deaths = new HashMap<Player, Integer>();
 
    int deathamount = 0;
 
    @EventHandler
    public void onPlayerDeath(PlayerDeathEvent event) {
 
        Player player = (Player) event.getEntity();
 
        deathamount++;
        deaths.remove(player);
        deaths.put(player, deathamount);
        Main.plugin.getConfig().set("stats." + player.getName() + ".deaths", deaths.get(player));
 
    }
 
    HashMap<Player, Integer> kills = new HashMap<Player, Integer>();
 
    int killamount = 0;
 
    @EventHandler
    public void onPlayerKill(PlayerDeathEvent event) {
 
        Player player = (Player) event.getEntity().getKiller();
 
        if(event.getEntity().getKiller() != null) {
 
            killamount++;
            kills.remove(player);
            kills.put(player, killamount);
            Main.plugin.getConfig().set("stats." + player.getName() + ".kills", kills.get(player));
 
        }
 
 
    }
 
    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event) {
        Player player = event.getPlayer();
 
        if(!player.hasPlayedBefore()) {
            kills.put(player, killamount);
            deaths.put(player, deathamount);
            Main.plugin.getConfig().set("stats." + player.getName() + ".kills", kills.get(player));
            Main.plugin.getConfig().set("stats." + player.getName() + ".deaths", deaths.get(player));
        }
    }
 
}
 

I am still getting an internal error when I type /stats, it displays the first message, [Stats], but follows with an internal error.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

No, but it will be. Very soon. Very, very soon. And when it does, you better be prepared

 

Lolmewn lol, got it, thanks

 

Lol I just barely saw another problem like this. What you're doing is your referencing a variable you declared at the top right?: private static Listeners listeners;. The problem is when you go to register these listeners instead of assigning the variable to a new Listeners class you just call the constrctor for a new listeners class. Simply add listeners = new Listeners() in your Plugin.getPluginManager.registerEvents()

haydenaa

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Cloaking_Ocean i'll try that, thanks

 

Cloaking_Ocean , done need to test it

 

haydenaa ok

 

Cloaking_Ocean Skionz Lolmewn AronTheGamer Thanks for the help guys, I greatly appreciate the help. I've managed to fix most of the bugs, and since this thread is on sending a hashmap's contents to a player, and i've figured out how to do this, I'm probably not going to be posting on here anymore. Again, thanks for the help

 

@haydenaa Your welcome, glad I could help!