Getting 10 of the online players?

Hello. I just want some way of getting 10 random playernames who are online on the server. I have no idea where to start.

Example:

Bukkit.BroadcastMessage(tenrandom);

would result in

Player1 Player2 Player3.(and all the way to).Player 10

Then of course a check if there aren't 10 people online

Code:

if(Bukkit.getServer().getOnlinePlayers().length > 10);

 

Make a random int

 

JordyPwner

I was more wondering how to get 10 names specifically and not all or one of them.

 

Didn't have time to test this, but it should work. As a side note, a regular list should work.

Code:java

if(Bukkit.getServer().getOnlinePlayers().length > 10){
            Random rand;
            LinkedList<String> pList= new LinkedList<String>();
            for(Player all:getServer().getOnlinePlayers()){
                pList.add(all.getName());
            }
            LinkedList<String> tenPlayers= new LinkedList<String>();
            for(int i=0;i<10;i++){
                rand = new Random();
                int randInt = rand.nextInt(i);
                tenPlayers.add(pList.get(randInt));
                pList.remove(randInt);
            }
            //TODO Get players from string in tenPlayers
        }

 

TheOatBaron
Why are you creating a new Random on each iteration?

 

Assist

Else it would use the same number I believe.

EDIT: It would work without it, the old one would keep getting a new String

EDIT 2: Just realized, it would be completely useless either way.

 

iSexyChocobo

Code:java

List<String> list = new ArrayList<String>();
for(int i = 0; list.size() < 10; i = new Random().nextInt(list.size() - 1)){
Player random = Bukkit.getOnlinePlayers()[i];
if(!list.contains(random.getName())) list.add(random.getName());
}[/i]

Now you have a list of playernames, you can get the players from the list now

 

Not only is that code difficult to read and very prone to errors, it doesn't even work in the first place.

 

Here's what I would do:

Code:java

// Copy the list of online players, then randomize the order
List<Player> players = new ArrayList<>(Bukkit.getOnlinePlayers());
Collections.shuffle(players);
// nPlayers is the number of players you would like to get
for (int i = 0; i < nPlayers; i++) {
    Player p = players.get(i);
    // ...
}

I have found Collections.shuffle to be useful for these types of things.

 

mythbusterma
Yeah I don't know what happened there, it should work now. I had some issues when posting it here because it would not [ i ] post but it would make the text cursive, it worked now

 

coasterman10

I'm getting a Dead Code warning on the

Code:

for (int i = 0; i < nPlayers; i++) {

line on the i++ part.

 

iSexyChocobo

Because you literally copy/pasted his code without thinking about it or even reading the comments....

 

mythbusterma

Yeah thanks for not being helpful.. and being wrong, I did read all the comments as well as the code.

Can someone actually help me now? I suppose that's what this forum is for? I didn't post here because I'm the best at java, I posted because I needed help with it.

 

msnijder30
That method wouldn't work if called again. Assuming no one leaves or joins, the same people would be called again.

 

Alright, well instead of being ignorant, I guess you're just not very good at this. The point is to understand the point of his code instead of just copy/pasting it. If you would've understand what he was saying you could've utilised his comment, but instead you don't. That was very helpful and the thread should be over, because it's answered.

 

mythbusterma
coasterman10

Alright I'll play it your way, I'll show you what I understand and then you can fill in the blanks.


List<Player> players = new ArrayList<>(Bukkit.getOnlinePlayers());
//This simply lists all the players into an arraylist
Collections.shuffle(players);
//Shuffling, randomizing the order of the list
for (int i = 0; i < nPlayers; i++) {
//I'm assuming I could either change nPlayers straight to the number or assign it trough Int nPlayers = 10
//The < signals "if nPlayers is bigger than int i"
// The left side states that i will now equal zero
// I have no idea what comes after the nPlayers thingy
Player p = players.get(i);
//Gets the 10 players. Now I can use it.
}

 

TheOatBaron
How do you mean?

 

1. Put all online players in a list.
2. Get a randomly chosen player from list
3. Remove that player from list
4. Repeat

You might have to do some more things then just that to make sure you don't get an OutOfBoundsException.