[Util] FireworkEffectPlayer v1.0

Found the packet it uses: Packet38EntityStatus

Soo i kept looking and found that the normal firework explodes using the same method as we're using: this.world.broadcastEntityEffect(this, (byte)17);

Now.. My brain is totally fried. Why is it that we see ALL regular fireworks explode fine, but when we force the effect it shows up about 50% of the time. I'm going to try and delay it a bit, see if that does any good.

 

Alright i found a semi-better method to get these fireworks to play. It still uses reflection of course, and is still codename_b's code, just i modifiy the private integer that designates how long the firework has flown. Soo this method still allows for minecraft to use it's native code to explode the fireworks, but simply "tricks" it into blowing it up instantly.

http://pastebin.com/NTp0mXtf

 

bob7 I made commands for both variants and tested them a few times and I couldn't experience a difference, the one with the ticksFlown fails as often as the one with the .detonate() method :/

 

DarkBladee12
It is working nice for me '-'

 

Got a bunch of people together on a server. This appears to be a 1.7 client bug. The strangest thing is some players will see a firework, and some wont. The effect limit isn't cutting off these fireworks, it's like the packet isn't being sent to all the clients within the view radius.

 

bob7 And i found an even better one

 

DevRosemberg Which one did you find that is better than the previously posted ones?

 

DarkBladee12 http://forums.bukkit.org/threads/util-fireworkeffectplayer-v2-0-no-nms-or-reflection-needed.216235/

 

DevRosemberg So I'm assuming you mean the second version, because the first version just uses .detonate() and the second one delays it. Did you test the second version a couple times and did it always work for you?

 

DarkBladee12 The second version also uses .detonate() which does absoultely everything which codename did here. The second one does not work with the delay and i recommend deleting it which i will do in some minutes. Thanks for making me remember it. And yes without the Delay it works perfeclty.

 

public static void getRandomEffect() {
return FireworkEffect.builder().withType(Type.BALL).withColor(Color.RED).build();
}
Gives me an error!

 

Norbu10 Your method is of a void type so you can't return anything...

 

Norbu10 By the way, that wouldnt return a random effect,
1) It wouldnt even return a FireworkEffect
2) If it would return a FireworkEffect it would return a specified one in this case a Big Ball with Red Color.
3) Try to do this instead:

Code:java

public static void spawnFirework(Location location) {
        Firework fw = (Firework) location.getWorld().spawnEntity(location, EntityType.FIREWORK);
        FireworkMeta fwm = fw.getFireworkMeta();
        Random r = new Random();
        int rt = r.nextInt(4) + 1;
        Type type = Type.BALL;
        if (rt == 1) type = Type.BALL;
        if (rt == 2) type = Type.BALL_LARGE;
        if (rt == 3) type = Type.BURST;
        if (rt == 4) type = Type.CREEPER;
        if (rt == 5) type = Type.STAR;
        int r1i = r.nextInt(17) + 1;
        int r2i = r.nextInt(17) + 1;
        Color c1 = getColor(r1i);
        Color c2 = getColor(r2i);
        FireworkEffect effect = FireworkEffect.builder().flicker(r.nextBoolean()).withColor(c1).withFade(c2).with(type).trail(r.nextBoolean()).build();
        fwm.addEffect(effect);
        int rp = r.nextInt(2) + 1;
        fwm.setPower(rp);
        fw.setFireworkMeta(fwm);
    }
 
    private static Color getColor(int i) {
        Color c = null;
        if(i==1){
            c=Color.AQUA;
        }
        if(i==2){
            c=Color.BLACK;
        }
        if(i==3){
            c=Color.BLUE;
        }
        if(i==4){
            c=Color.FUCHSIA;
        }
        if(i==5){
            c=Color.GRAY;
        }
        if(i==6){
            c=Color.GREEN;
        }
        if(i==7){
            c=Color.LIME;
        }
        if(i==8){
            c=Color.MAROON;
        }
        if(i==9){
            c=Color.NAVY;
        }
        if(i==10){
            c=Color.OLIVE;
        }
        if(i==11){
            c=Color.ORANGE;
        }
        if(i==12){
            c=Color.PURPLE;
        }
        if(i==13){
            c=Color.RED;
        }
        if(i==14){
            c=Color.SILVER;
        }
        if(i==15){
            c=Color.TEAL;
        }
        if(i==16){
            c=Color.WHITE;
        }
        if(i==17){
            c=Color.YELLOW;
        }
        return c;
    }

 

You should use a switch statement, it looks better IMO.

Code:

private Color getColor(int i) {
        Color c = null;
       
        switch(i) {
            case 1: c = Color.AQUA;
                break;
            case 2: c = Color.BLACK;
                break;
            case 3: c = Color.BLUE;
                break;
            case 4: c = Color.FUCHSIA;
                break;
            case 5: c = Color.GRAY;
                break;
            case 6: c = Color.GREEN;
                break;
            case 7: c = Color.LIME;
                break;
            case 8: c = Color.MAROON;
                break;
            case 9: c = Color.NAVY;
                break;
            case 10: c = Color.OLIVE;
                break;
            case 11: c = Color.ORANGE;
                break;
            case 12: c = Color.PURPLE;
                break;
            case 13: c = Color.RED;
                break;
            case 14: c = Color.SILVER;
                break;
            case 15: c = Color.TEAL;
                break;
            case 16: c = Color.WHITE;
                break;
            case 17: c = Color.YELLOW;
                break;
        }
 
        return c;
    }

 

codename_B why are you simulating all methods, instead of only sending the packet?

 

Because YOLO.

 

Thats the true meaning of life, we do everything because YOLO.

 

There should definetely a PlaySoundEvent or whatever where you can cancel such stuff when you got the event.getHandler() or something

Sorry, that was offtopic

 

Oh cool ... (I'm bad to speak English )
Codename_B can you share that : ?


I make a similar effect :




and that :

Show Spoiler Hide Spoiler

Show Spoiler Hide Spoiler

 

coco5843
http://forums.bukkit.org/threads/154406/
That's what creates those effects.

 

Thank's --" but I know that , Codename_B spawn effects in spiral !

 

How old are you? It's not "that" hard after taking some Trig classes.

 

you ask my age because I did not express myself properly?

excuse me, I'm doing my best, I'm French

The trig classes ? what's ? can you give me an exemple ?

oh trigonometry classes

But how codename_B implement trig classes ?

 

I would like to know this as well. Does anyone know how to do this?

 

I don't know how to spawn fireworks without sound either.

 

Maybe spawning the particles in a sphere, but then it could lag and would only be either white or random colored

 

codename_B

Code:java

FireworkEffectPlayer fplayer = new FireworkEffectPlayer();
                    fplayer.playFirework(player.getWorld(), player.getLocation(), FireworkEffect.builder().with(Type.BALL_LARGE).build()) ;

How would I create my 'own' effect. Or did I just went full retard?

Dubehh
Stupid me. Didn't read. got it xD

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

http://forums.bukkit.org/threads/in...ible-rocket-just-the-explosion-effect.269919/

Maybe you should throw a link to this in your post.

 

NerdsWBNerds Look mate, getting resources popular isnt easy. It has to be something attractive or something improved about another resource. You going to other FireworkLibs and posting it is spam and in this case bumping an old thread which is not well seen here. Just wait for your resource to get popular if it deserves to be. If not work on a new and improved one. Im telling you this as an advice, not to mock you.

 

To spawn fireworks without sound, look up the source for detonate, and change/delete the playSound.