Player Damager from EntityDamageEvent

Hey everyone I need to get a Players Damager using the EntityDamageEvent but as player.getDamager() only works in EntityDamageByEntityEvent I am forced to ask this Question... I need to see if the Attacking Entity is a Player, I have tried if(player.getLastDamageCause().getEntity() instanceof Player) but it doesn't work... so my Question is :

"How would I make it so that the Code checks the Players Damager and to see if it is a Player"

I need this Urgently as I have a Personal dead-line on this Plugin. Any Help would be much appreciated.

NOTE : Please Tahg me if you respond so I am notified when I come on the Bukkit Forums.

Cheers -
FatAussieFatBoy

 

Code:text

player.getLastDamageCause().getEntity() instanceof Player

How comes this doesn't work?

Code:text

 
Entity e = player.getLastDamageCause().getEntity();
if(e!=null) {
   if(e instanceof Player) {
      Player p = (Player) e;
      // Do more stuff
    }
}
 

 

DCDJ
Not to sure why, that's why I am asking the Question...
But on another Note just to add to the Question, how do I get the DamageCause from a Player
DamageCause.ENTITY_ATTACK doesn't work either...

 

just use EntityDamageByEntityEvent event! it saves hassle

Code:java

public void onEntityDamage(EntityDamageByEntityEvent event){
Entity damager = event.getDamager();
if (damager instanceof Player){
//do stuff here
}
}

 

I mean, as in, do you get any exceptions thrown/stack-trace in the console? Or does it just do nothing at all?
The method player.getLastDamageCause() and sub-methods are working for me inside the EntityDamageEvent event, so this is a little strange. Perhaps you could post some more code?

 

DCDJ
I can post my whole Event if you would like but, I use custom references from my Classes so some pieces of code may look out of place...

Code:java

@EventHandler
    public void onPlayerEDE(EntityDamageEvent e) {
        if(e.getEntity() instanceof Player) {
            Player p = (Player) e.getEntity();
            DamageCause cause = e.getCause();
            setArena(p);
            Arena a = arena;
            if(a != null) {
                String arenaName = a.getName();
                if(a.getPlayers().contains(p.getName())) {
                    Damageable damge = p;
                    if(cause == DamageCause.ENTITY_ATTACK) {
                        if(p.getLastDamageCause().getEntity() instanceof Player) {
                            Player pl = (Player) p.getLastDamageCause().getEntity();
                            if(a.getPlayers().contains(pl.getName())) {
                                if(a.getJuggernaut().equals(p)) {
                                    if(damge.getHealth() - e.getDamage() < 1.5) {
                                        if(a.isInGame()) {
                                            a.setJuggernaut(pl);
                                            a.sendMessage(prefix + msg + "The Juggernaut has been killed!");
                                            a.sendMessage(prefix + gold + pl.getName() + msg + " is the New Juggernaut!");
                                            statsConfig.set("stats." + pl.getName() + ".coins", + 5);
                                            GameEvents.getEvent().playerRespawn(p);
                                        }else{
                                            p.setHealth(damge.getMaxHealth());
                                            p.setFireTicks(0);
                                            p.setFoodLevel(20);
                                            p.teleport(a.getLobby());
                                        }
                                    }else if(damge.getHealth() - e.getDamage() < 1) {
                                        if(a.isInGame()) {
                                            e.setCancelled(true);
                                            p.setHealth((double) 1);
                                        }
                                    }
                                }else if(!a.getJuggernaut().equals(p) && !a.getJuggernaut().equals(pl)){
                                    e.setCancelled(true);
                                    pl.sendMessage(prefix + error + "Sorry, FriendlyFire is turned off in Juggernaut!");
                                }
                            }
                        }else{
                            p.sendMessage(ChatColor.DARK_PURPLE + "The Entity is not a Player!");
                        }
                    }else{
                        p.sendMessage(ChatColor.DARK_PURPLE + "You are not being attacked by a Entity or Player!");
                        if(a.getJuggernaut().equals(p)) {
                            if(damge.getHealth() - e.getDamage() < 1.5) {
                                if(a.isInGame()) {
                                    statsConfig.set("stats." + p.getName() + ".coins", - 5);
                                    if(statsConfig.getInt("stats." + p.getName() + ".coins") < 0) {
                                        statsConfig.set("stats." + p.getName() + ".coins", 0);
                                    }
                                    GameEvents.getEvent().playerRespawn(p);
                                    GameEvents.getEvent().JuggernautSelect(arenaName);
                                }else{
                                    p.setHealth(damge.getMaxHealth());
                                    p.setFireTicks(0);
                                    p.setFoodLevel(20);
                                    p.teleport(a.getLobby());
                                }
                            }
                        }else{
                            if(damge.getHealth() - e.getDamage() < 1.5) {
                                if(a.isInGame()) {
                                    statsConfig.set("stats." + p.getName() + ".coins", - 5);
                                    if(statsConfig.getInt("stats." + p.getName() + ".coins") < 0) {
                                        statsConfig.set("stats." + p.getName() + ".coins", 0);
                                    }
                                    GameEvents.getEvent().playerRespawn(p);
                                }else{
                                    p.setHealth(damge.getMaxHealth());
                                    p.setFireTicks(0);
                                    p.setFoodLevel(20);
                                    p.teleport(a.getLobby());
                                }
                            }
                        }
                    }
                }else{
                    p.sendMessage(ChatColor.DARK_PURPLE + "This Player is not in the Arena!");
                }
            }else{
                p.sendMessage(ChatColor.DARK_PURPLE + "Arena is Null!");
            }
        }
    }

mrZcr4fter I have already tried to use the EntityDamageByEntityEvent but can't use it as the EntityDamageEvent overrides the Priority of use, no matter what I set the EventPriority to on the EntityDamageByEntityEvent the EntityDamageEvent overrides it :/

 

FatAussieFatBoy

And this is why you don't set deadlines. You end up putting in unnecessary tags like "[URGENT]" resulting in SLOWER help.

 

The_Doctor_123
When I say "Personal Dead-line" I mean I can only work on this Plugin for a Set amount of time before I have to make others for my Clients... This Plugin is for my MC Server and I need it Urgently as I can not waste anymore time on this Error (already spent over 3 Days trying to fix it).

So please if you "Can Help" then please Tahg Me in a response.

Cheers -
FatAussieFatBoy