[Chat] Kill counter prefix

I need some tips/help on how to make a kill counter prefix

Example: [<Amount of kills>] <PlayerName>

Here's what I know so far:
1.It's something todo with PlayerChatEvent or AsyncPlayerChatEvent and needs counter and ints/numbers also to do with player.setFormat but that's all I know so I need help with the rest.

 

Code:java

int kills = <Amount of kills>;
String format = event.getFormat();
event.setFormat("[" + kills + "] " + format);

 

How would a make this go up when the player kills a player ?

Something todo with PlayerDeathEvent and kills + 1?

Example: A player has [0] the player kills a other player they now have [1] then the player that has [1] gets killed so the player now has [0] again so the player that killed this player now has [1]. Hope this makes sense if it doesn't please tell me.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:java

 @EventHandler
public void onPlayerDeath(PlayerDeathEvent event) {
if(event.getEntity().getKiller() instanceof Player) {
Player killer = event.getEntity().getKiller();
//TODO: Get kills of killer, increment the value by one and save the new value.
}
}

Take a look to this Tutorial. It's about saving and loading of YAML files.
To save the values permanently you have to use files/databases and I think the easiest and best way is to use a YAML file.

 

@Devils0s thanks I'll do this now.

 

Please use the thanks button.

 

@DevilOs So i would add something like this?

Code:java

killer.setDisplayName(ChatColor.GRAY + "{ " + ChatColor.GOLD + kills
                        + ChatColor.GRAY + " }");

How do you spell your username?

Then add some like kills +1 somewhere?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

historio Yes. You can now easily kills++;.

 

I did this:

Code:java

killer.setDisplayName(ChatColor.GRAY + "{ " + ChatColor.GOLD + kills + 1
                        + ChatColor.GRAY + " }");

How would I keep this repeating and how would I remove it if the player dies?

Bump.

This is all my code so far (hope this helps you help me):

Code:java

import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.player.AsyncPlayerChatEvent;
import org.bukkit.event.player.PlayerJoinEvent;
 
public class ChatListener implements Listener {
 
public int kills = 0;
 
@EventHandler
public void OnPlayerChat(AsyncPlayerChatEvent e) {
int kills = 0;
String format = e.getFormat();
e.setFormat("[" + kills + "] " + format);
}
 
@EventHandler
public void onPlayerjoin(PlayerJoinEvent e) {
Player p = e.getPlayer();
p.setDisplayName(ChatColor.GRAY + "{ " + ChatColor.GOLD + kills
+ ChatColor.GRAY + " }");
}
 
@EventHandler
public void PlayerDeath(PlayerDeathEvent e) {
if(e.getEntity().getKiller() instanceof Player) {
Player killer = e.getEntity().getKiller();
killer.setDisplayName(ChatColor.GRAY + "{ " + ChatColor.GOLD + kills + 1
+ ChatColor.GRAY + " }");
 
}
 
}
}
 

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Code:java

Player victim = event.getEntity();

Get the victim and set the victims kills to 0.​

That only set it to 0 if the victim is killed by a player.​

Accidents or killed by NPCs don't count.​

​

You have to save the players and their kills (I would prefer a HashMap) and then read out and update the values.​

Code:java

 
 
public HashMap<Player, Integer> kills = new HashMap<Player, Integer>();
 
@EventHandler
public void onPlayerDeath(PlayerDeathEvent event) {
if(event.getEntity().getKiller() instanceof Player) {
Player killer = event.getEntity().getKiller();
Player victim = event.getEntity();
if(!kills.containsKey(killer)) kills.put(killer, 0);
if(!kills.containsKey(victim)) kills.put(victim, 0);
 
kills.put(killer, kills.get(killer)+1);
kills.put(victim, 0);
}
}

That should work.
To get the amount of a player use the kills.get(player); method that returns the current kills value.

Code:java

 if(!kills.containsKey(player)) kills.put(player, 0);
int killAmount = kills.get(player);

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

Using a hash map would work, but personally I'd work straight out a yml file. Someone already linked to the tutorial about configuration files.
On player death, int kills = config.getInt(playerName)
Config.set(playerName, kills++)

Same for player that died, but then kills--

 

historio
If you want it to be {Kills} <name> then you should do this aswell:

Code:java

public HashMap<String, int> nameKills = new HashMap<>();
@EventHandler
public void playerDeath(PlayerDeathEvent e) {
  if(e.getEntity().getKiller() instanceof Player) {
    Player killer = e.getEntity().getKiller();
    killer.setDisplayName(ChatColor.GRAY + "{" + (nameKills.get(killer.getName) + 1) + "}" + killer.getName());
    nameKills.put(killer.getName(), nameKills.get(killer.getName) + 1);
  }
}

 

Resolved?

 

autoit4you Only justed tested it now and I'm getting errors



The other errors are the same too.

 

replace

Code:text

public int kills = 0;

with

Code:text

public HashMap<String, int> kills = new HashMap<String, int>();

also remove the setdisplayname in onPlayerJoin as the kills are should be shown on every chat event(with the OnPlayerChat).

 

autoit4you I get this error on the int it says "Syntax error on token "int", Dimensions expected after this "

Code:java

public HashMap<String, int> kills = new HashMap<String, int>();

 

Okay change int to Integer

 

autoit4you Now "put" is giving me an error "The method put(String, Integer) in the type HashMap<String,Integer> is not applicable for the arguments (Player, int)"

Code:java

if (!kills.containsKey(killer))
                kills.put(killer, 0);
            if (!kills.containsKey(victim))
                kills.put(victim, 0);
 
            kills.put(killer, kills.get(killer) + 1);
            kills.put(victim, 0);

autoit4you Sorry if I'm being annoying

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

replace killer with killer.getName()

 

@aurotoit4you My server console now gives me this error:

Code:

14:11:44 [SEVERE] Could not pass event PlayerDeathEvent to AdvancedKitPvP v3.0
org.bukkit.event.EventException
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:427)
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.jav
a:62)
        at org.bukkit.plugin.TimedRegisteredListener.callEvent(TimedRegisteredLi
stener.java:30)
        at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.j
ava:478)
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.j
ava:463)
        at org.bukkit.craftbukkit.v1_5_R3.event.CraftEventFactory.callPlayerDeat
hEvent(CraftEventFactory.java:340)
        at net.minecraft.server.v1_5_R3.EntityPlayer.die(EntityPlayer.java:294)
        at net.minecraft.server.v1_5_R3.EntityLiving.damageEntity(EntityLiving.j
ava:764)
        at net.minecraft.server.v1_5_R3.EntityHuman.damageEntity(EntityHuman.jav
a:684)
        at net.minecraft.server.v1_5_R3.EntityPlayer.damageEntity(EntityPlayer.j
ava:359)
        at net.minecraft.server.v1_5_R3.EntityHuman.attack(EntityHuman.java:874)
 
        at net.minecraft.server.v1_5_R3.PlayerConnection.a(PlayerConnection.java
:1124)
        at net.minecraft.server.v1_5_R3.Packet7UseEntity.handle(SourceFile:36)
        at org.spigotmc.netty.NettyNetworkManager.b(NettyNetworkManager.java:218
)
        at net.minecraft.server.v1_5_R3.PlayerConnection.d(PlayerConnection.java
:115)
        at net.minecraft.server.v1_5_R3.ServerConnection.b(SourceFile:35)
        at org.spigotmc.MultiplexingServerConnection.b(MultiplexingServerConnect
ion.java:72)
        at net.minecraft.server.v1_5_R3.MinecraftServer.r(MinecraftServer.java:5
83)
        at net.minecraft.server.v1_5_R3.DedicatedServer.r(DedicatedServer.java:2
27)
        at net.minecraft.server.v1_5_R3.MinecraftServer.q(MinecraftServer.java:4
72)
        at net.minecraft.server.v1_5_R3.MinecraftServer.run(MinecraftServer.java
:404)
        at net.minecraft.server.v1_5_R3.ThreadServerApplication.run(SourceFile:5
73)
Caused by: java.lang.NullPointerException
        at me.historio13.AdvancedKitPvp.ChatListener.onPlayerDeath(ChatListener.
java:35)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        at java.lang.reflect.Method.invoke(Unknown Source)
        at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.ja
va:425)
        ... 21 more

 

What is in the line 35?

 

autoit4you ?

 

Code:

at me.historio13.AdvancedKitPvp.ChatListener.onPlayerDeath(ChatListener.
java:35)

Just give me the current code of the onPlayerDeath function

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

autoit4you

Here is my Chatlistener code:

Code:java

package me.historio13.AdvancedKitPvp;
 
import java.util.HashMap;
 
import org.bukkit.ChatColor;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.entity.PlayerDeathEvent;
import org.bukkit.event.player.AsyncPlayerChatEvent;
 
public class ChatListener implements Listener {
 
public HashMap<String, Integer> kills = new HashMap<String, Integer>();
 
@EventHandler(priority = EventPriority.HIGHEST)
public void OnPlayerChat(AsyncPlayerChatEvent e) {
int kills = 0;
String format = e.getFormat();
e.setFormat(ChatColor.GRAY + "{ " + ChatColor.GOLD + kills
+ ChatColor.GRAY + " } " + ChatColor.RESET + format);
}
 
@EventHandler(priority = EventPriority.HIGHEST)
public void onPlayerDeath(PlayerDeathEvent event) {
if (event.getEntity().getKiller() instanceof Player) {
Player killer = event.getEntity().getKiller();
Player victim = event.getEntity();
if (!kills.containsKey(killer))
kills.put(killer.getName(), 0);
if (!kills.containsKey(victim))
kills.put(victim.getName(), 0);
 
kills.put(killer.getName(), kills.get(killer) + 1);
kills.put(victim.getName(), 0);
}
}
}
 

and here is my main class code:

Code:java

package me.historio13.AdvancedKitPvp;
 
import java.util.logging.Logger;
 
import org.bukkit.event.Listener;
import org.bukkit.plugin.PluginDescriptionFile;
import org.bukkit.plugin.java.JavaPlugin;
 
public final class AdvancedKitPvp extends JavaPlugin implements Listener {
 
public final Logger logger = Logger.getLogger("minecraft");
public static AdvancedKitPvp Plugin;
 
@Override
public void onEnable() {
getServer().getPluginManager().registerEvents(this, this);
getCommand("akp").setExecutor(new AdvancedKitPvpCommandExecutor());
getServer().getPluginManager()
.registerEvents(new Eventlistener(), this);
getServer().getPluginManager().registerEvents(new ChatListener(), this);
}
 
@Override
public void onDisable() {
PluginDescriptionFile pdfFile = this.getDescription();
this.logger.info(pdfFile.getName() + " has been Disabled!");
}
}

 

try this:

Code:java

@EventHandler(priority = EventPriority.HIGHEST)
public void onPlayerDeath(PlayerDeathEvent event) {
if (event.getEntity().getKiller() instanceof Player) {
Player killer = event.getEntity().getKiller();
Player victim = event.getEntity();
if (!kills.containsKey(killer.getName()))
kills.put(killer.getName(), 0);
if (!kills.containsKey(victim.getName()))
kills.put(victim.getName(), 0);
 
kills.put(killer.getName(), kills.get(killer.getName()) + 1);
kills.put(victim.getName(), 0);
}
}

 

autoit4you I have no errors now but its not doing anything when a player dies.

 

are you sure?

replace the OnPlayerChat function with this:

Code:java

@EventHandler(priority = EventPriority.HIGHEST)
public void OnPlayerChat(AsyncPlayerChatEvent e) {
int killAmount = 0;
if(kills.containsKey(e.getPlayer().getName())
  killAmount = kills.get(e.getPlayer().getName());
String format = e.getFormat();
e.setFormat(ChatColor.GRAY + "{ " + ChatColor.GOLD + kills
+ ChatColor.GRAY + " } " + ChatColor.RESET + format);
}

Then kill another player and then write something in the chat.

 

autoit4you It looks like this


How would I make it look like this?

{1} <Player>
{0} historio13

autoit4you Again I'm sorry if I'am being annoying.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

You did nothing wrong I just forgot to change kills to killAmount:

Code:java

e.setFormat(ChatColor.GRAY + "{ " + ChatColor.GOLD + killAmount
+ ChatColor.GRAY + " } " + ChatColor.RESET + format);

Edit:
You do not annoy me

 

autoit4you Thanks now I'm going to have a go at saving these kills.

autoit4you would I do somelike this to save the kills?

EDIT by Moderator: merged posts, please use the edit button instead of double posting.